Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(appdata): Improve appdata for AppStream 1.0 #179

Merged
merged 2 commits into from Jan 1, 2024
Merged

feat(appdata): Improve appdata for AppStream 1.0 #179

merged 2 commits into from Jan 1, 2024

Conversation

ghost
Copy link

@ghost ghost commented Dec 31, 2023

  • Add the <developer><name> tag
  • Mark the <developer_name> tag as deprecated

- Add the `<developer><name>` tag
- Mark the `<developer_name>` tag as deprecated
@GeopJr
Copy link
Owner

GeopJr commented Dec 31, 2023

LGTM overall, thanks!

Just one question:

Your suggested id is github.com and the spec mentions The element should have a id property, containing a unique ID to identify the respective developer. It is recommended to use a web URL, like gnome.org as ID to achieve a higher chance of uniqueness.. I don't mind it but if it was chosen just because the app is on github, I'd probably choose something else as I don't know if it will stay here forever. I am not entirely sure what's the point of the id is either based on the spec, is it to distinguish me or the app? Would gnome.org (I am a member fwiw) or no id at all be better instead?

@ghost
Copy link
Author

ghost commented Jan 1, 2024

I've opened an issue regarding Appstream. You can find it here: Issue #575. Feel free to contribute to the discussion or provide any insights you may have.

@GeopJr GeopJr merged commit 02361a6 into GeopJr:main Jan 1, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants