Fix 22 - accumulate remainder in Lines.makeAsyncIterator #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the PR planned in #22. A fix is the 1-character change (
+=) in the last commit, to accumulate the remainder when there are missing delimiters.The first five commits are tests, then enough delimiter implementation to demo the bug, and then the test that fails without the fix.
For testing, I'm not confident that the way I wrapped Script is the best, since it puts validation inside the script. Also it seems there should be an easier way to drive the bug test.
I imagine there may be API issues with the delimiters and terminators used to drive the test, but I'm assuming we can address those in a PR for #20, which I'll base off these changes. Since that PR includes these changes, you might find it easier to just go through those commits.
Thanks!