Segmented lines, #22 fix, and splitInput for #20 #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the discussion on #24, this variant for #20 is intended as minimal.
For Shwift it has the original fix for #22 and split Line segments.
For Script it has only
splitInput. That includes a reducing operation and thus is (properly) not usable as pipe source. It could be renamed tosplitInputAndReducefor clarity, but it's the only split API and the parameters and type make its operation pretty clear.The reduce operation takes a String rather than an AsyncSequence of String. It's simpler and doesn't lose much useful functionality (and I couldn't get that working :)