Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete old useless jstests folder #4481

Merged
merged 1 commit into from
Feb 3, 2025
Merged

Conversation

submarcos
Copy link
Member

Description

jstests is an old folder that test frontend and routing with caspjerjs / phantomjs.

capserjs an phantomjs are deprecated.
frontend test is handle by cypress
routing is now handle by backend

Related Issue

Checklist

  • I have followed the guidelines in our Contributing document
  • My code respects the Definition of done available in the Development section of the documentation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes
  • I added an entry in the changelog file
  • My commits are all using prefix convention (emoji + tag name) and references associated issues
  • I added a label to the PR corresponding to the perimeter of my contribution
  • The title of my PR mentionned the issue associated

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.46%. Comparing base (e41fcfa) to head (49d6ffd).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4481   +/-   ##
=======================================
  Coverage   98.46%   98.46%           
=======================================
  Files         269      269           
  Lines       21471    21471           
=======================================
  Hits        21142    21142           
  Misses        329      329           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Feb 3, 2025

Geotrek-admin    Run #10917

Run Properties:  status check passed Passed #10917  •  git commit 4510420423 ℹ️: Merge 49d6ffd1b3c0c8afd7c46c56ea8680102930057b into b3bfd2291efc774a098fad6f76f2...
Project Geotrek-admin
Branch Review refs/pull/4481/merge
Run status status check passed Passed #10917
Run duration 02m 00s
Commit git commit 4510420423 ℹ️: Merge 49d6ffd1b3c0c8afd7c46c56ea8680102930057b into b3bfd2291efc774a098fad6f76f2...
Committer Jean-Etienne Castagnede
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 22
View all changes introduced in this branch ↗︎

@submarcos submarcos marked this pull request as ready for review February 3, 2025 14:11
@submarcos submarcos merged commit d7ba9c8 into master Feb 3, 2025
21 checks passed
@submarcos submarcos deleted the delete_deprecated_jstest_folder branch February 3, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant