Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to customize develoment postgres docker image in .env file #4483

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

submarcos
Copy link
Member

Description

Default postres / postgis / pgrouting docker image in development can now be override in development by using POSTGRES_IMAGE=xxx in you .env file

Related Issue

Checklist

  • I have followed the guidelines in our Contributing document
  • My code respects the Definition of done available in the Development section of the documentation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes
  • I added an entry in the changelog file
  • My commits are all using prefix convention (emoji + tag name) and references associated issues
  • I added a label to the PR corresponding to the perimeter of my contribution
  • The title of my PR mentionned the issue associated

@submarcos submarcos added the 🛠️ Tools Configurations liés a l’environnement de développement label Feb 4, 2025
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.46%. Comparing base (c6da840) to head (0300296).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4483   +/-   ##
=======================================
  Coverage   98.46%   98.46%           
=======================================
  Files         269      269           
  Lines       21473    21473           
=======================================
  Hits        21144    21144           
  Misses        329      329           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Feb 4, 2025

Geotrek-admin    Run #10925

Run Properties:  status check passed Passed #10925  •  git commit a07dfa89ec ℹ️: Merge 030029647f5708d733c512334a4e8c19da9572d0 into c6da8402f7b30682407130647155...
Project Geotrek-admin
Branch Review refs/pull/4483/merge
Run status status check passed Passed #10925
Run duration 02m 03s
Commit git commit a07dfa89ec ℹ️: Merge 030029647f5708d733c512334a4e8c19da9572d0 into c6da8402f7b30682407130647155...
Committer Jean-Etienne Castagnede
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 22
View all changes introduced in this branch ↗︎

@submarcos submarcos marked this pull request as ready for review February 4, 2025 14:09
@submarcos submarcos merged commit fd72966 into master Feb 4, 2025
18 checks passed
@submarcos submarcos deleted the allow_customize_pgimage_in_dev branch February 4, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛠️ Tools Configurations liés a l’environnement de développement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant