Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💫 [IMPR] Add sensitive areas to mobile API and sync #4490

Merged
merged 14 commits into from
Feb 14, 2025

Conversation

justinefricou
Copy link
Contributor

@justinefricou justinefricou commented Feb 11, 2025

Description

Related Issue

Checklist

  • I have followed the guidelines in our Contributing document
  • My code respects the Definition of done available in the Development section of the documentation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes
  • I added an entry in the changelog file
  • My commits are all using prefix convention (emoji + tag name) and references associated issues
  • I added a label to the PR corresponding to the perimeter of my contribution
  • The title of my PR mentionned the issue associated

@justinefricou justinefricou force-pushed the add_sensitive_areas_to_api_mobile branch from b670488 to 6967f65 Compare February 11, 2025 14:55
@justinefricou justinefricou changed the title Add sensitive areas to api mobile [💫 IMPR] Add sensitive areas to api mobile Feb 11, 2025
@justinefricou justinefricou changed the title [💫 IMPR] Add sensitive areas to api mobile 💫 [IMPR] Add sensitive areas to api mobile Feb 11, 2025
Copy link

cypress bot commented Feb 11, 2025

Geotrek-admin    Run #11027

Run Properties:  status check passed Passed #11027  •  git commit 7209488add ℹ️: Merge 9cb15df4a21ec4bad4bd39001118b8a07101f20e into 891c845494bcd0f75202d04f5d4b...
Project Geotrek-admin
Branch Review refs/pull/4490/merge
Run status status check passed Passed #11027
Run duration 01m 57s
Commit git commit 7209488add ℹ️: Merge 9cb15df4a21ec4bad4bd39001118b8a07101f20e into 891c845494bcd0f75202d04f5d4b...
Committer Justine Fricou
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 22
View all changes introduced in this branch ↗︎

@justinefricou justinefricou changed the title 💫 [IMPR] Add sensitive areas to api mobile 💫 [IMPR] Add sensitive areas to mobile API Feb 11, 2025
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.47%. Comparing base (891c845) to head (9cb15df).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4490   +/-   ##
=======================================
  Coverage   98.46%   98.47%           
=======================================
  Files         269      270    +1     
  Lines       21473    21522   +49     
=======================================
+ Hits        21144    21193   +49     
  Misses        329      329           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justinefricou justinefricou changed the title 💫 [IMPR] Add sensitive areas to mobile API 💫 [IMPR] Add sensitive areas to mobile API and sync Feb 13, 2025
@justinefricou justinefricou force-pushed the add_sensitive_areas_to_api_mobile branch from 25f8af1 to 9cb15df Compare February 14, 2025 12:00
@justinefricou justinefricou marked this pull request as ready for review February 14, 2025 13:23
@justinefricou justinefricou requested a review from a team February 14, 2025 13:24
@justinefricou justinefricou merged commit 5bfa09a into master Feb 14, 2025
22 checks passed
@justinefricou justinefricou deleted the add_sensitive_areas_to_api_mobile branch February 14, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants