Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

noqa on get_ipython #34

Closed
nim65s opened this issue Aug 8, 2023 · 1 comment
Closed

noqa on get_ipython #34

nim65s opened this issue Aug 8, 2023 · 1 comment

Comments

@nim65s
Copy link
Member

nim65s commented Aug 8, 2023

exclude: gepetuto/magic.py

This won't prevent manual runs of ruff . to fail. I think you should instead add hints in the file : either a # noqa: F821 in the end of each line where there is a get_ipython, or a # ruff: noqa: F821 at the begining of the file.

A better solution might be to add a def run(self, magic) method, which run get_ipython().run_line_magic(magic) with the correct noqa only once, and use this method in the other places.

Originally posted by @nim65s in #24 (comment)

@nim65s
Copy link
Member Author

nim65s commented Aug 8, 2023

fixed by #36

@nim65s nim65s closed this as completed Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant