Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dark mode support #649

Merged
merged 6 commits into from
Nov 16, 2024
Merged

Add dark mode support #649

merged 6 commits into from
Nov 16, 2024

Conversation

nitori
Copy link
Contributor

@nitori nitori commented Nov 16, 2024

Fixes #648

This adds dark mode support for mask in TYPO3 13.

Since the SCSS color variables where only few, and a lot of colors where actually hardcoded, I simply replaced them with CSS variables everywhere.

There where a few styles in the SCSS I could not link to specific areas in the Module, e.g. the icon picker, that seems to have been removed?

Anyway, here is a sample screenshot:

image

Greetings
Nitori

@nhovratov
Copy link
Collaborator

nhovratov commented Nov 16, 2024

Woow, nice!! Thank you ❤️

Yes, Icon Picker is removed since v12. You can remove the styling altogether.

@nitori
Copy link
Contributor Author

nitori commented Nov 16, 2024

I'll do that then.

There is also the .mask-shared-info class that has a white-ish background and blue border, but I couldn't identify where that is, as well as .form-switch.checkbox-invert .form-check-input:checked that has a white background, but it might not be relevant as it's only a checkbox (couldn't find it either).

I left those untouched.

@nitori
Copy link
Contributor Author

nitori commented Nov 16, 2024

Nvm. I found the latter in "select" type.
image

@nhovratov
Copy link
Collaborator

.mask-shared-info: This could be the little blue icon at the bottom left of a field, when fields are shared between elements.

@nitori
Copy link
Contributor Author

nitori commented Nov 16, 2024

That doesn't seem to be the case. That one uses mask-field__multiuse. Which is just an inline svg icon.

I tried to make that one brighter actually, but it doesn't seem to work with CSS variables.
At least not in Chrome as far as I could find out - so I left it as it is.

@nhovratov nhovratov merged commit 840b8d1 into Gernott:main Nov 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add dark mode for Backend Module for TYPO3 13
2 participants