-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide text_format render element for string schema properties #4132
Labels
Comments
stefan-korn
added a commit
to stefan-korn/dkan
that referenced
this issue
Feb 22, 2024
3 tasks
stefan-korn
added a commit
to stefan-korn/dkan
that referenced
this issue
Feb 22, 2024
stefan-korn
added a commit
to stefan-korn/dkan
that referenced
this issue
Feb 22, 2024
Hi Stefan - I like this concept. Flagging @dgading. |
dafeder
pushed a commit
that referenced
this issue
Dec 23, 2024
dafeder
pushed a commit
that referenced
this issue
Dec 23, 2024
9 tasks
Updated this with test coverage, docs and codeclimate fixes @stefan-korn. Hoping to merge soon. Hope it is still useful to you after all this time! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
User Story
Editors want to use text_format render elements for long text fields (currently designated via textarea widget in schema.ui.json), for example to edit long text in CKEditor.
Acceptance Criteria
Caveats
It is not (easily) possible to store the format together with the string in json. Therefore I would propose to not store the format in the JSON and keep this fixed in the schema.ui.json. So it will be allowed only one format (via allowed_formats) in the text format widget and no changing is possible via UI.
The output of the string needs to be taken care independently. For example currently the node--data template escapes any HTML in the string (though I suppose it is not even necessary here, because Twig does escaping itself).
If you want to output HTML in the description you need to change this and take care yourself. You also need to ensure that only the HTML you want is output, so maybe custom processing is needed (but this is done anyway via metastore_preprocess_node__data), so you can do it like there for yourself.
The text was updated successfully, but these errors were encountered: