-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide text_format render element in JSON Form Widget #4371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dafeder
changed the title
Test re-roll 4132
Provide text_format render element in JSON Form Widget
Dec 26, 2024
3 tasks
janette
requested changes
Dec 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We held off as long as we could :)
Just the closing quote then this is good to go.
janette
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4132
Re-roll of #4133 by @stefan-korn
This provides an option in the UI Schema to define a Drupal text format for a textarea property. It only affects JSON Form widget forms, not any rendering or API response. We may do a follow-up to reflect this in the twig template or accompanying theme preprocess function. For now, what this achieves is replacing the bare textarea element on a form with a text_format element.
It does not allow a selection of all text formats available in Drupal, but locks a particular property in to a particular text format (as this is only about presentation and there is nowhere to store entity-specific format information).
I also added some test coverage to the
mailto:
fix as we kept getting dinged on that in coverage reports (even though that code needs to be replaced at some point).QA Steps
Checklist before requesting review
If any of these are left unchecked, please provide an explanation