Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated data dictionary widget functional test to test all fields in the form and the data dictionary and index field displays. #4265

Merged

Conversation

dmundra
Copy link
Contributor

@dmundra dmundra commented Aug 26, 2024

re 22001

Describe your changes

Updated functional test for #4185

QA Steps

  • Tests are passing in the pipeline and locally with the following command:
ddev dkan-phpunit \
                    --coverage-clover /var/www/html/docroot/modules/contrib/dkan/clover.xml \
                    --coverage-html /var/www/html/docroot/modules/contrib/dkan/coverage-html \
                    --log-junit /var/www/html/docroot/modules/contrib/dkan/junit/junit.xml --filter DataDictionaryWidgetTest

…the form and the data dictionary and index field displays.
Copy link
Contributor

@rovcase rovcase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've ran the tests and they pass as well as I've followed along with the steps and the check the main functions. Looks good, thanks a bunch!

$page->fillField('field_json_metadata[0][indexes][fields][field_collection][group][index][fields][name]', $test_index_name);
$page->fillField('field_json_metadata[0][indexes][fields][field_collection][group][index][fields][length]', $test_index_length);
// Need to distinguish the add button on the index fields vs the one for data dictionary fields.
$page->pressButton('Add ');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Odd that this has a space after but good that it allows for a distinguishment between the two, we should probably make this more unique in later iterations, something like "add new index field".

@rovcase rovcase merged commit 69f1e64 into Data-Dictionary-Index-Working Aug 29, 2024
8 checks passed
@rovcase rovcase deleted the 22001-datadictionary-functional-test branch August 29, 2024 15:44
dmundra added a commit that referenced this pull request Sep 6, 2024
…the form and the data dictionary and index field displays. (#4265)
beeyayjay pushed a commit that referenced this pull request Jan 6, 2025
…the form and the data dictionary and index field displays. (#4265)
beeyayjay pushed a commit that referenced this pull request Jan 6, 2025
…the form and the data dictionary and index field displays. (#4265)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants