Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Indexes edit unit tests #4266

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Added Indexes edit unit tests #4266

merged 1 commit into from
Aug 30, 2024

Conversation

dmundra
Copy link
Contributor

@dmundra dmundra commented Aug 27, 2024

re: 22002

Describe your changes

Tests for #4185

QA Steps

  • Tests are passing in the pipeline and locally with the following command:
ddev dkan-phpunit \                                                                                                                 
                    --coverage-clover /var/www/html/docroot/modules/contrib/dkan/clover.xml \
                    --coverage-html /var/www/html/docroot/modules/contrib/dkan/coverage-html \
                    --log-junit /var/www/html/docroot/modules/contrib/dkan/junit/junit.xml --filter DataDictionaryWidgetBuildIndexesTest

rovcase
rovcase approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@rovcase rovcase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job covering the additional edit functionalities here, thanks for working on this, LGTM!

@rovcase rovcase merged commit ded9dcd into Data-Dictionary-Index-Working Aug 30, 2024
8 checks passed
@rovcase rovcase deleted the 22002-datadictionary-index-edit-unit-tests branch August 30, 2024 14:46
dmundra added a commit that referenced this pull request Sep 6, 2024
@dmundra
Added Indexes edit unit tests (#4266)
887202f
beeyayjay pushed a commit that referenced this pull request Jan 6, 2025
@dmundra
Added Indexes edit unit tests (#4266)
eb0c8a3
beeyayjay pushed a commit that referenced this pull request Jan 6, 2025
@dmundra
Added Indexes edit unit tests (#4266)
b10bd49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rovcase rovcase rovcase approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmundra @rovcase