Update contributing documentation. Add new issue templates.

.github/ISSUE_TEMPLATE/feature_request.yml

@@ -6,8 +6,8 @@ labels: [feature request]
 body:
   - type: textarea
     attributes:
-      label: Feature Description
-      description: "Briefly describe the feature you would like to see added to the project."
+      label: User Story
+      description: "As a [user], I want [goal] so that [some reason]."
       placeholder: "Provide a brief overview of the feature..."
     validations:
       required: true
@@ -54,7 +54,7 @@ body:
 
   - type: textarea
     attributes:
-      label: Additional Context
-      description: "Provide any additional context, such as similar features in other projects, screenshots, or mockups."
+      label: Acceptance Criteria
+      description: Set up the scenario. Given [x] When [y] Then [z].
     validations:
       required: false

.github/ISSUE_TEMPLATE/task.yml

@@ -0,0 +1,16 @@
+name: Task
+description: A workitem that needs to be done while developing a story, feature, addressing tech debt, documentation, etc.
+labels: [task]
+
+body:
+  - type: textarea
+    attributes:
+     label: Description
+     description: A concise description of the task or suggested implementation.
+     render: markdown
+  - type: textarea
+    attributes:
+      label: Acceptance Criteria
+      description: Tell us what should happen, how will we know when we're done.
+      render: markdown
+

.gitignore

@@ -17,3 +17,4 @@ tagfile
 /web
 .phpunit.result.cache
 docs/build
+docs/.venv

cypress/integration/08_admin_views.spec.js

@@ -48,6 +48,7 @@ context('Admin content and dataset views', () => {
         cy.get('input[aria-controls="select2-edit-field-json-metadata-0-value-keyword-keyword-0-results"]').type('open data{enter}')
         // End filling up keyword.
         cy.get('#edit-submit').click({ force:true })
+        cy.wait(2000)
         cy.get('.button').contains('Yes').click({ force:true })
         cy.get('.messages--status').should('contain','has been created')
     })

docs/source/conf.py

@@ -19,11 +19,11 @@
 # -- Project information -----------------------------------------------------
 
 project = 'DKAN Documentation'
-copyright = '2023, CivicActions'
+copyright = '2024, CivicActions'
 author = 'CivicActions'
 
 # The full version, including alpha/beta/rc tags
-release = '2.15.2'
+release = '2.19.2'
 version = '2.x'
 
 # -- General configuration ---------------------------------------------------

docs/source/contributing/code_of_conduct.rst

@@ -1,2 +1,89 @@
-.. include:: ../../../CODE_OF_CONDUCT.md
-    :parser: myst_parser.docutils_
+Code of Conduct
+===============
+
+Purpose
+-------
+
+A primary goal of the Project DKAN is to be inclusive to the largest number of participants, with the most varied and diverse backgrounds possible. As such, we are committed to providing a friendly, safe and welcoming environment for all, regardless of gender, sexual orientation, ability, ethnicity, socioeconomic status, and religion (or lack thereof).
+
+This code of conduct outlines our expectations for all those who participate in our community, as well as the consequences for unacceptable behavior.
+
+We invite all those who participate in Project DKAN activities to help us create safe and positive experiences for everyone.
+
+Open source & culture citizenship
+---------------------------------
+
+A supplemental goal of this Code of Conduct is to increase open source and culture citizenship by encouraging participants to recognize and strengthen the relationships between our actions and their effects on our community.
+
+Communities mirror the societies in which they exist and positive action is essential to counteract the many forms of inequality and abuses of power that exist in society.
+
+If you see someone who is making an extra effort to ensure our community is welcoming, friendly, and encourages all participants to contribute to the fullest extent, please recognize their efforts.
+
+Expected Behavior
+-----------------
+
+The following behaviors are expected and requested of all community members:
+
+- Participate in an authentic and active way. In doing so, you contribute to the health and longevity of this community.
+- Exercise consideration and respect in your speech and actions.
+- Attempt collaboration before conflict.
+- Refrain from demeaning, discriminatory, or harassing behavior and speech.
+- Be mindful of your surroundings and of your fellow participants. Alert community leaders if you notice a dangerous situation, someone in distress, or violations of this Code of Conduct, even if they seem inconsequential.
+- Keep conversations in appropriate channels to help people find the information they need.
+
+Unacceptable behavior
+---------------------
+
+The following behaviors are considered harassment and are unacceptable within our community:
+
+- Violence, threats of violence or violent language directed against another person.
+- Sexist, racist, homophobic, transphobic, ableist or otherwise discriminatory jokes and language.
+- Posting or displaying sexually explicit or violent material.
+- Posting or threatening to post other people's personally identifying information ("doxing").
+- Personal insults, particularly those related to gender, sexual orientation, race, religion, or disability.
+- Inappropriate photography or recording.
+- Unwelcome sexual attention. This includes, sexualized comments or jokes and unwelcomed sexual advances.
+- Deliberate intimidation, stalking or following (online or in person).
+- Advocating for, or encouraging, any of the above behavior.
+- Promoting your particular product or service (though we of course welcome relevant recommendations).
+
+
+Consequences of unacceptable behavior
+-------------------------------------
+
+Unacceptable behavior from any community member, including sponsors and those with decision-making authority, will not be tolerated.
+
+Anyone asked to stop unacceptable behavior is expected to comply immediately.
+If a community member engages in unacceptable behavior, we may take any action deemed appropriate, up to and including a temporary ban or permanent expulsion from the community without warning.
+
+**Reporting guidelines**
+
+If you are subject to or witness unacceptable behavior, or have any other concerns, please notify us as soon as possible by emailing [email protected].
+
+Addressing grievances
+---------------------
+
+Only permanent resolutions (such as bans) may be appealed. To appeal a decision of the working group, contact the Project DKAN team at [email protected] with your appeal and the team will review the case.
+
+Scope
+-----
+
+We expect all community participants (contributors, paid or otherwise; sponsors; and other guests) to abide by this Code of Conduct in all community venues–online and in-person–as well as in all one-on-one communications pertaining to community business.
+
+This code of conduct and its related procedures also applies to unacceptable behavior occurring outside the scope of community activities when such behavior has the potential to adversely affect the safety and well-being of community members.
+
+Contributing
+------------
+
+Learn more about :doc:`contributing <../contributing/index>` here.
+
+Contact info
+------------
+
+Project DKAN, [email protected]
+
+
+License and attribution
+-----------------------
+
+This Code of Conduct is distributed under a `Creative Commons Attribution-ShareAlike license <http://creativecommons.org/licenses/by-sa/3.0/>`_. Portions of text derived from the `Django Code of Conduct <https://www.djangoproject.com/conduct/>`_ and the `Geek Feminism Anti-Harassment Policy <http://geekfeminism.wikia.com/wiki/Conference_anti-harassment/Policy>`_.

docs/source/contributing/index.rst

@@ -5,6 +5,7 @@ Contributing
    :maxdepth: 1
 
    submission_guidelines
-   documentation
    code_of_conduct
+   documentation
+   support
    license

docs/source/contributing/submission_guidelines.rst

@@ -18,6 +18,17 @@ Our efforts will be focused on the 2.x version of DKAN. If you are reporting a b
 and it is not a security issue, we encourage you to reach out on the
 `DKAN Discussions <https://github.com/GetDKAN/dkan/discussions>`_.
 
+Setting up a local development sandbox
+--------------------------------------
+
+We recomend using DDEV with the DDEV-DKAN add-on as there are many helpful commands that will make it easier to get started.
+Once you have composer, docker, and DDEV `installed <https://dkan.readthedocs.io/en/latest/installation/index.html>`_, head over to `Getting Started with DDEV-DKAN <https://getdkan.github.io/ddev-dkan/getting-started.html>`_
+
+Issues tagged Good First Issue
+------------------------------
+
+Issues tagged with the "Good First Issue" tag have been identified by experienced contributors as having some aspect that should be easy for a new contributor to do.
+
 Submitting a Pull Request (PR)
 ------------------------------
 
@@ -34,3 +45,8 @@ and push the changes to your GitHub repository, which will automatically update
 At all times, please ensure the automated build passes so that a minimal amount of tests are passed for your code.
 
 After your PR is merged, you can safely delete your branch and pull the changes from the main (upstream) repository.
+
+Coding Standards
+----------------
+
+`Coder <http://drupal.org/project/coder>`_ is a tool to help write code for Drupal modules. It can detect and automatically fix coding standard errors. The project provides a coding standard for PHP_CodeSniffer based on the `Drupal coding standard <https://www.drupal.org/docs/develop/standards/php/php-coding-standards>`_

docs/source/contributing/support.rst

@@ -0,0 +1,18 @@
+Support and Help
+================
+
+Github issues should not be used as a support forum. Please use `DKAN Discussions <https://github.com/GetDKAN/dkan/discussions>`_ for questions about the project.
+
+Please seek support in the following ways:
+
+  #. Read the `documentation <https://dkan.readthedocs.io/en/latest/>`_ and other guides for the project to see if you can figure it out on your own. These are also located in the root docs/ directory.
+  #. Check that you're on the latest version before reporting an issue.
+  #. Check the issue queue for the same or similar issues to the one you're having.
+  #. Search for answers and ask questions on `DKAN Discussions <https://github.com/GetDKAN/dkan/discussions>`_. This is the most appropriate place for debugging issues specific to your use of the project, or figuring out how to use the project in a specific way. Please clearly explain what you are trying to do, and list what you have already attempted to solve the problem. Provide code samples, but do not attach your entire project for someone else to debug.
+  #. Come back and tell the community if a particular solution worked for you or not. You will help people who come after you.
+
+Be patient. DKAN maintainers work full time on projects that support the development of the module and may be slow to respond to discussions depending on work loads.
+
+Reporting a security issue
+--------------------------
+If you have found a vunerability in DKAN, please report this by e-mailing [email protected].

docs/source/installation/index.rst

@@ -27,24 +27,22 @@ DKAN is based on `Drupal software <https://www.drupal.org/docs/getting-started/s
 -  Drush: minimum version 11.x.
 -  Node: minimum version 18 (if using the decoupled frontend)
 
-Starting a new DKAN project
----------------------------
+Starting a new DKAN project with DDEV
+-------------------------------------
 
 Follow the instructions from the **DKAN DDEV Add-on** documentation: `Starting a new project <https://getdkan.github.io/ddev-dkan/getting-started.html>`_ to generate a new Drupal site with DKAN installed on your system.
 
+
+Starting a new DKAN project with Composer
+-----------------------------------------
 DKAN DDEV Add-on bases new projects off of a `composer project <https://github.com/GetDKAN/recommended-project>`_ that you can also use to start a project using your own toolset:
 
   .. prompt:: bash $
 
     composer create-project getdkan/recommended-project my-project
 
-Or simply create a project however you prefer and add a requirement for `getdkan/dkan`.
-
-.. warning::
-   Do note that a bug in Drupal core cron may cause problems with data imports, and applying `this patch <https://www.drupal.org/project/drupal/issues/3274931>`_ is highly recommended. The patch will be applied automatically if you use the `recommended project <https://github.com/GetDKAN/recommended-project>`_.
-
 Adding DKAN into an existing project
-----------------------------------------
+------------------------------------
 
 If you already have an existing Drupal site, install DKAN with `composer <https://www.drupal.org/node/2718229>`_. You can find the `latest DKAN release here <https://github.com/GetDKAN/dkan/releases>`_. Composer will download the module and all of the dependencies it requires for the backend.
 
@@ -53,7 +51,11 @@ If you already have an existing Drupal site, install DKAN with `composer <https:
       composer require 'getdkan/dkan'
       drush en dkan
 
-To start with some example datasets:
+.. warning::
+   Do note that a bug in Drupal core cron may cause problems with data imports, and applying `this patch <https://www.drupal.org/project/drupal/issues/3274931>`_ is highly recommended. The patch will be applied automatically if you use the `recommended project <https://github.com/GetDKAN/recommended-project>`_.
+
+Add some example datasets to your site
+--------------------------------------
 
   .. prompt:: bash $