Make response stream max age a configuration

[zedmonds96]

Fixes see 21638

Describe your changes

• Added datastore_response_stream_max_age to datastore.settings.yml with a default of 3600 seconds.
• Updated DatastoreSettingsForm to include a configurable field for response stream max-age.
• Modified QueryDownloadController to use the configured response_stream_max_age instead of a hardcoded value.

QA Steps

• Access the Datastore Settings form.
• Modify the Response Stream Max-Age value and save the form.
• Confirm that the new value is saved in the configuration
• If no configuration is set, ensure the default 3600 seconds is applied.

Checklist before requesting review

If any of these are left unchecked, please provide an explanation

• I have updated or added tests to cover my code
• [N/A] I have updated or added documentation

[dafeder]

@zedmonds96 set this back to draft as tests are failing. Are you still working on this?

[paul-m]

This method needs a docblock update, but not because of your changes. :-)

It needs two @params and also @returns a MockObject and not a Chain.

[zedmonds96]

Docblock now looks like this:

/**
   * Create a mock object for the main container passed to the controller.
   *
   * @param int $rowLimit
   *    The row limit for a query.
   * @param int|null $responseStreamMaxAge
   *    The max age for the response stream in cache, or NULL to use the default.
   * @param array $info
   *   Dataset info array mock to be returned by DatasetInfo::gather().
   *
   * @return \PHPUnit\Framework\MockObject\MockObject
   *   MockChain mock object.
   */

[paul-m]

Thanks, but there's no $info parameter.

[zedmonds96]

That was there before, I didn't add it. Should I remove it?

[paul-m]

Yes please.