Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request adds a new functionality to the pydkan package: the ability to not only use
username/password
but alsotokens
.The Good
api = DatasetAPI(uri, user, password)
we doapi = DatasetAPI(uri, token)
assumingtoken
has already being defined.tokens
.README
has been updated.The Bad
api = DatasetAPI(uri, token, True)
. If usingtoken
and want to set debug toTrue
the way to do that isapi = DatasetAPI(uri, token, debug=True)
.token
argument (at least with that name), soapi = DatasetAPI(uri, token=token, debug=True)
won't work.The Missing