[CHA-536] support campaign user pagination #188
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -1,5 +1,5 @@ | |||
| import sys | |||
| from typing import Dict, List, Optional | |||
| from typing import Dict, List, Optional, Union | |||
There was a problem hiding this comment.
[flake8] <401> reported by reviewdog 🐶
'typing.Union' imported but unused
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
| ) -> Union[StreamResponse, Awaitable[StreamResponse]]: | ||
| """ | ||
| Create a campaign | ||
| Get a campaign | ||
|
|
There was a problem hiding this comment.
[black] reported by reviewdog 🐶
| from stream_chat.types.campaign import ( | ||
| CampaignData, | ||
| QueryCampaignsOptions, | ||
| GetCampaignOptions, |
There was a problem hiding this comment.
📝 [flake8] <1> reported by reviewdog 🐶
isort found an import in the wrong position
| from stream_chat.types.campaign import ( | ||
| CampaignData, | ||
| QueryCampaignsOptions, | ||
| GetCampaignOptions, |
There was a problem hiding this comment.
📝 [flake8] <1> reported by reviewdog 🐶
isort found an import in the wrong position
| ) -> Union[StreamResponse, Awaitable[StreamResponse]]: | ||
| """ | ||
| Create a campaign | ||
| Get a campaign | ||
|
|
There was a problem hiding this comment.
blank line contains whitespace
| from stream_chat.types.campaign import ( | ||
| CampaignData, | ||
| QueryCampaignsOptions, | ||
| GetCampaignOptions, |
There was a problem hiding this comment.
📝 [flake8] <1> reported by reviewdog 🐶
isort found an import in the wrong position
| def get_campaign( | ||
| self, campaign_id: str, options: Optional[GetCampaignOptions] = None | ||
| ) -> StreamResponse: | ||
| params = {} |
There was a problem hiding this comment.
🚫 [mypy] reported by reviewdog 🐶
Need type annotation for "params" (hint: "params: dict[, ] = ...") [var-annotated]
| async def get_campaign( | ||
| self, campaign_id: str, options: Optional[GetCampaignOptions] = None | ||
| ) -> StreamResponse: | ||
| params = {} |
There was a problem hiding this comment.
🚫 [mypy] reported by reviewdog 🐶
Need type annotation for "params" (hint: "params: dict[, ] = ...") [var-annotated]
Ticket
Related PR
CLA
Description of the pull request