Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Enable tap function on parent message of Thread #2251

Conversation

atsss
Copy link
Contributor

@atsss atsss commented Oct 10, 2023

🎯 Goal

  • The parent message is enabled to execute press functions in a thread

🛠 Implementation details

  • Currently, users can't execute press functions on the parent messages in a thread.
    • Can't open URL inside of parent messages in a thread
    • Can't add any reactions to parent messages in a thread
    • Can't quote parent messages in a thread
  • Aimed for the same specs as Slack
RPReplay_Final1696902794_compressed.mp4

🎨 UI Changes

iOS

Before

before_ios_compressed.mp4

After

after_ios_compressed.mp4
Android

Before

before_android.-.Compressed.with.FlexClip.mp4

After

after_android.-.Compressed.with.FlexClip.mp4

🧪 Testing

☑️ Checklist

  • I have signed the Stream CLA (required)
  • PR targets the develop branch
  • Documentation is updated
  • New code is tested in main example apps, including all possible scenarios
    • SampleApp iOS and Android
    • Expo iOS and Android

@atsss atsss changed the title Enable tap function on parent message of Thread Fix: Enable tap function on parent message of Thread Oct 10, 2023
@khushal87
Copy link
Member

Hey @atsss, we can only allow normal press here and with your solution the long press is also enabled for the thread message. Can you look forward to targeting the normal press event somehow? Thanks 😄

@khushal87
Copy link
Member

Closing it as it has been stale for a long time.

@khushal87 khushal87 closed this Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants