Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue with camera permissions when clicking the camera picker #2315

Merged
merged 3 commits into from
Nov 20, 2023

Conversation

khushal87
Copy link
Member

🎯 Goal

Fixes iOS issue with open setting when camera permissions are given and clicked on cancel button when camera picker is clicked.
Fixes android issue of unresponsive behaviour when permission denied twice.

🛠 Implementation details

🎨 UI Changes

iOS
Before After
Android
Before After

🧪 Testing

☑️ Checklist

  • I have signed the Stream CLA (required)
  • PR targets the develop branch
  • Documentation is updated
  • New code is tested in main example apps, including all possible scenarios
    • SampleApp iOS and Android
    • Expo iOS and Android

@santhoshvai santhoshvai merged commit 2e39142 into develop Nov 20, 2023
@santhoshvai santhoshvai deleted the fix-camera-permissions branch November 20, 2023 15:34
@github-actions github-actions bot mentioned this pull request Nov 20, 2023
6 tasks
@stream-ci-bot
Copy link
Contributor

🎉 This PR is included in version 5.22.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants