Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not send two upload requests when offline support is enabled #2328

Merged
merged 6 commits into from
Nov 24, 2023
Merged

fix: do not send two upload requests when offline support is enabled #2328

merged 6 commits into from
Nov 24, 2023

Conversation

santhoshvai
Copy link
Member

🎯 Goal

🛠 Implementation details

🎨 UI Changes

iOS
Before After
Android
Before After

🧪 Testing

☑️ Checklist

  • I have signed the Stream CLA (required)
  • PR targets the develop branch
  • Documentation is updated
  • New code is tested in main example apps, including all possible scenarios
    • SampleApp iOS and Android
    • Expo iOS and Android

@santhoshvai santhoshvai marked this pull request as ready for review November 24, 2023 09:00
@santhoshvai santhoshvai merged commit c05b335 into develop Nov 24, 2023
6 checks passed
@santhoshvai santhoshvai deleted the fix-upload-requests branch November 24, 2023 09:49
@github-actions github-actions bot mentioned this pull request Nov 24, 2023
Merged
6 tasks
@stream-ci-bot
Copy link
Contributor

🎉 This PR is included in version 5.22.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khushal87 khushal87 khushal87 left review comments

@vishalnarkhede vishalnarkhede vishalnarkhede approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@santhoshvai @stream-ci-bot @vishalnarkhede @khushal87