fix: null check attachment duration #2348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khushal87
approved these changes
Dec 21, 2023
santhoshvai
pushed a commit
that referenced
this pull request
Jan 12, 2024
santhoshvai
added a commit
that referenced
this pull request
Jan 18, 2024
* fix: channel around message performance issues * batching data * fhinal fixes * restart interval on copy messages state * remove debug text * fix test * fix: message action list item title theme (#2352) * fix: null check attachment duration (#2348) * fix: width and height passed to ImageResizer were reversed (#2350) At least based on the latest documentation, the width should come before height: https://github.com/bamlab/react-native-image-resizer?tab=readme-ov-file#usage-example * feat: compress images selected through file picker while upload (#2359) * docs: update example apps README.md with latest steps (#2355) * docs: update example apps README.md with latest steps * refactor: delete examples/ExpoMessaging/Readme.md * refactor: dev setup and sample app docs removed * docs: add examples directory README.md * chore: pin vale version * sample app, fix unread counts * fix: initial unread scroll --------- Co-authored-by: Khushal Agarwal <[email protected]> Co-authored-by: Tao Qian <[email protected]>
|
🎉 This PR is included in version 5.23.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
We saw the following crash
🛠 Implementation details
🎨 UI Changes
iOS
Android
🧪 Testing
☑️ Checklist
developbranch