Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add back formattedDate prop to MessageFooter #2528

Merged
merged 2 commits into from
May 28, 2024

Conversation

khushal87
Copy link
Member

@khushal87 khushal87 commented May 28, 2024

🎯 Goal

We mistakenly removed the formattedDate prop from the MessageFooter component and introduced a date prop in #2514. In this PR, we add back the prop and allow both modes of data passing in the component.

🛠 Implementation details

🎨 UI Changes

iOS
Before After
Android
Before After

🧪 Testing

☑️ Checklist

  • I have signed the Stream CLA (required)
  • PR targets the develop branch
  • Documentation is updated
  • New code is tested in main example apps, including all possible scenarios
    • SampleApp iOS and Android
    • Expo iOS and Android

@khushal87 khushal87 requested a review from oliverlaz May 28, 2024 10:47
@khushal87 khushal87 merged commit e553d50 into develop May 28, 2024
5 of 6 checks passed
@khushal87 khushal87 deleted the formatted-date-prop branch May 28, 2024 11:15
@github-actions github-actions bot mentioned this pull request May 28, 2024
6 tasks
@stream-ci-bot
Copy link
Contributor

🎉 This PR is included in version 5.31.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants