-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove usage of flatlist-mvcp in favour of mvcp support in RN >= 0.72 #2539
Merged
Merged
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
ae279a1
fix: add expo-clipboard to peer deps of expo-package (#2537)
khushal87 ae1c1a8
feat: remove usage of flatlist-mvcp in favour of mvcp support in RN >…
khushal87 1c850f9
fix: remove flatlist-mvcp from example apps
khushal87 d47f756
chore: update peer dep of react native
khushal87 0830f0c
chore: resolve conflicts from branch v6.0.0
khushal87 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7327,10 +7327,10 @@ [email protected]: | |
version "0.0.0" | ||
uid "" | ||
|
||
stream-chat-react-native-core@5.29.0: | ||
version "5.29.0" | ||
resolved "https://registry.yarnpkg.com/stream-chat-react-native-core/-/stream-chat-react-native-core-5.29.0.tgz#b89d5f954c2063316ab6dc254e0b98188f01524d" | ||
integrity sha512-cm8CQUIHPE+hHxM1hVQ6V3ogUJLpGPRZBvMYbJW7+MBdhUTn4+40EqEbqHTEtHdkLgPUmxaDJsh/gFCtVEGgog== | ||
stream-chat-react-native-core@5.31.1: | ||
version "5.31.1" | ||
resolved "https://registry.yarnpkg.com/stream-chat-react-native-core/-/stream-chat-react-native-core-5.31.1.tgz#4367276c8316d325e6b062e4efb95d464d4e2eef" | ||
integrity sha512-EKHMQ0bWRoyubTxk1IKEbkIzcIY5hxHDpyGU7ObGXLLnhoVBEDranZBQ7dNDdbuM88uKh9mGK5WH4NQSTioKxQ== | ||
dependencies: | ||
"@gorhom/bottom-sheet" "4.4.8" | ||
dayjs "1.10.5" | ||
|
@@ -7342,27 +7342,12 @@ [email protected]: | |
path "0.12.7" | ||
react-native-markdown-package "1.8.2" | ||
react-native-url-polyfill "^1.3.0" | ||
stream-chat "8.17.0" | ||
stream-chat "8.31.0" | ||
|
||
"stream-chat-react-native-core@link:../../package": | ||
version "0.0.0" | ||
uid "" | ||
|
||
[email protected]: | ||
version "8.17.0" | ||
resolved "https://registry.yarnpkg.com/stream-chat/-/stream-chat-8.17.0.tgz#01c4aacbcdb5dd734b088e70f40cd42a0bcd0fb7" | ||
integrity sha512-0cYKSroKGiLilElk8Ol6AKAowWIIpXz3wsY97o+cAqixOwwHdnbuPZ00L2CzAjNB2c94Vl5L48n1K+9iOEpv3w== | ||
dependencies: | ||
"@babel/runtime" "^7.16.3" | ||
"@types/jsonwebtoken" "~9.0.0" | ||
"@types/ws" "^7.4.0" | ||
axios "^1.6.0" | ||
base64-js "^1.5.1" | ||
form-data "^4.0.0" | ||
isomorphic-ws "^4.0.1" | ||
jsonwebtoken "~9.0.0" | ||
ws "^7.4.4" | ||
|
||
[email protected]: | ||
version "8.31.0" | ||
resolved "https://registry.yarnpkg.com/stream-chat/-/stream-chat-8.31.0.tgz#387ed3109ac930e222bf260d98afc37dd1fcb1ac" | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2061,11 +2061,6 @@ | |
dependencies: | ||
"@sinonjs/commons" "^3.0.0" | ||
|
||
"@stream-io/[email protected]": | ||
version "0.10.3" | ||
resolved "https://registry.yarnpkg.com/@stream-io/flat-list-mvcp/-/flat-list-mvcp-0.10.3.tgz#774e56aba7f3da5a8f2ae5ad3065f05e5a27e7f2" | ||
integrity sha512-2ZK8piYlEfKIPZrH8BpZz9uj8HZcUvMCV0X7qSLSAc/vhLOANBfR0SSn0OaWPbqb2mFGAd4FxmLSPp1zKEYuaw== | ||
|
||
"@types/babel__core@^7.1.14": | ||
version "7.20.5" | ||
resolved "https://registry.yarnpkg.com/@types/babel__core/-/babel__core-7.20.5.tgz#3df15f27ba85319caa07ba08d0721889bb39c017" | ||
|
@@ -6825,10 +6820,10 @@ statuses@~1.5.0: | |
resolved "https://registry.yarnpkg.com/statuses/-/statuses-1.5.0.tgz#161c7dac177659fd9811f43771fa99381478628c" | ||
integrity sha512-OpZ3zP+jT1PI7I8nemJX4AKmAX070ZkYPVWV/AaKTJl+tXCTGyVdC1a4SL8RUQYEwk/f34ZX8UTykN68FwrqAA== | ||
|
||
stream-chat-react-native-core@5.29.0: | ||
version "5.29.0" | ||
resolved "https://registry.yarnpkg.com/stream-chat-react-native-core/-/stream-chat-react-native-core-5.29.0.tgz#b89d5f954c2063316ab6dc254e0b98188f01524d" | ||
integrity sha512-cm8CQUIHPE+hHxM1hVQ6V3ogUJLpGPRZBvMYbJW7+MBdhUTn4+40EqEbqHTEtHdkLgPUmxaDJsh/gFCtVEGgog== | ||
stream-chat-react-native-core@5.31.1: | ||
version "5.31.1" | ||
resolved "https://registry.yarnpkg.com/stream-chat-react-native-core/-/stream-chat-react-native-core-5.31.1.tgz#4367276c8316d325e6b062e4efb95d464d4e2eef" | ||
integrity sha512-EKHMQ0bWRoyubTxk1IKEbkIzcIY5hxHDpyGU7ObGXLLnhoVBEDranZBQ7dNDdbuM88uKh9mGK5WH4NQSTioKxQ== | ||
dependencies: | ||
"@gorhom/bottom-sheet" "4.4.8" | ||
dayjs "1.10.5" | ||
|
@@ -6840,7 +6835,7 @@ [email protected]: | |
path "0.12.7" | ||
react-native-markdown-package "1.8.2" | ||
react-native-url-polyfill "^1.3.0" | ||
stream-chat "8.17.0" | ||
stream-chat "8.31.0" | ||
|
||
"stream-chat-react-native-core@link:../../package": | ||
version "0.0.0" | ||
|
@@ -6850,21 +6845,6 @@ [email protected]: | |
version "0.0.0" | ||
uid "" | ||
|
||
[email protected]: | ||
version "8.17.0" | ||
resolved "https://registry.yarnpkg.com/stream-chat/-/stream-chat-8.17.0.tgz#01c4aacbcdb5dd734b088e70f40cd42a0bcd0fb7" | ||
integrity sha512-0cYKSroKGiLilElk8Ol6AKAowWIIpXz3wsY97o+cAqixOwwHdnbuPZ00L2CzAjNB2c94Vl5L48n1K+9iOEpv3w== | ||
dependencies: | ||
"@babel/runtime" "^7.16.3" | ||
"@types/jsonwebtoken" "~9.0.0" | ||
"@types/ws" "^7.4.0" | ||
axios "^1.6.0" | ||
base64-js "^1.5.1" | ||
form-data "^4.0.0" | ||
isomorphic-ws "^4.0.1" | ||
jsonwebtoken "~9.0.0" | ||
ws "^7.4.4" | ||
|
||
[email protected]: | ||
version "8.31.0" | ||
resolved "https://registry.yarnpkg.com/stream-chat/-/stream-chat-8.31.0.tgz#387ed3109ac930e222bf260d98afc37dd1fcb1ac" | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2364,11 +2364,6 @@ | |
dependencies: | ||
"@sinonjs/commons" "^3.0.0" | ||
|
||
"@stream-io/[email protected]": | ||
version "0.10.3" | ||
resolved "https://registry.yarnpkg.com/@stream-io/flat-list-mvcp/-/flat-list-mvcp-0.10.3.tgz#774e56aba7f3da5a8f2ae5ad3065f05e5a27e7f2" | ||
integrity sha512-2ZK8piYlEfKIPZrH8BpZz9uj8HZcUvMCV0X7qSLSAc/vhLOANBfR0SSn0OaWPbqb2mFGAd4FxmLSPp1zKEYuaw== | ||
|
||
"@types/babel__core@^7.1.14": | ||
version "7.20.1" | ||
resolved "https://registry.yarnpkg.com/@types/babel__core/-/babel__core-7.20.1.tgz#916ecea274b0c776fec721e333e55762d3a9614b" | ||
|
@@ -6882,10 +6877,10 @@ statuses@~1.5.0: | |
resolved "https://registry.yarnpkg.com/statuses/-/statuses-1.5.0.tgz#161c7dac177659fd9811f43771fa99381478628c" | ||
integrity sha512-OpZ3zP+jT1PI7I8nemJX4AKmAX070ZkYPVWV/AaKTJl+tXCTGyVdC1a4SL8RUQYEwk/f34ZX8UTykN68FwrqAA== | ||
|
||
stream-chat-react-native-core@5.29.0: | ||
version "5.29.0" | ||
resolved "https://registry.yarnpkg.com/stream-chat-react-native-core/-/stream-chat-react-native-core-5.29.0.tgz#b89d5f954c2063316ab6dc254e0b98188f01524d" | ||
integrity sha512-cm8CQUIHPE+hHxM1hVQ6V3ogUJLpGPRZBvMYbJW7+MBdhUTn4+40EqEbqHTEtHdkLgPUmxaDJsh/gFCtVEGgog== | ||
stream-chat-react-native-core@5.31.1: | ||
version "5.31.1" | ||
resolved "https://registry.yarnpkg.com/stream-chat-react-native-core/-/stream-chat-react-native-core-5.31.1.tgz#4367276c8316d325e6b062e4efb95d464d4e2eef" | ||
integrity sha512-EKHMQ0bWRoyubTxk1IKEbkIzcIY5hxHDpyGU7ObGXLLnhoVBEDranZBQ7dNDdbuM88uKh9mGK5WH4NQSTioKxQ== | ||
dependencies: | ||
"@gorhom/bottom-sheet" "4.4.8" | ||
dayjs "1.10.5" | ||
|
@@ -6897,7 +6892,7 @@ [email protected]: | |
path "0.12.7" | ||
react-native-markdown-package "1.8.2" | ||
react-native-url-polyfill "^1.3.0" | ||
stream-chat "8.17.0" | ||
stream-chat "8.31.0" | ||
|
||
"stream-chat-react-native-core@link:../../package": | ||
version "0.0.0" | ||
|
@@ -6912,21 +6907,6 @@ stream-chat-react-native-devtools@^1.1.0: | |
version "0.0.0" | ||
uid "" | ||
|
||
[email protected]: | ||
version "8.17.0" | ||
resolved "https://registry.yarnpkg.com/stream-chat/-/stream-chat-8.17.0.tgz#01c4aacbcdb5dd734b088e70f40cd42a0bcd0fb7" | ||
integrity sha512-0cYKSroKGiLilElk8Ol6AKAowWIIpXz3wsY97o+cAqixOwwHdnbuPZ00L2CzAjNB2c94Vl5L48n1K+9iOEpv3w== | ||
dependencies: | ||
"@babel/runtime" "^7.16.3" | ||
"@types/jsonwebtoken" "~9.0.0" | ||
"@types/ws" "^7.4.0" | ||
axios "^1.6.0" | ||
base64-js "^1.5.1" | ||
form-data "^4.0.0" | ||
isomorphic-ws "^4.0.1" | ||
jsonwebtoken "~9.0.0" | ||
ws "^7.4.4" | ||
|
||
[email protected]: | ||
version "8.31.0" | ||
resolved "https://registry.yarnpkg.com/stream-chat/-/stream-chat-8.31.0.tgz#387ed3109ac930e222bf260d98afc37dd1fcb1ac" | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2929,10 +2929,10 @@ [email protected]: | |
resolved "https://registry.yarnpkg.com/stream-buffers/-/stream-buffers-2.2.0.tgz#91d5f5130d1cef96dcfa7f726945188741d09ee4" | ||
integrity sha512-uyQK/mx5QjHun80FLJTfaWE7JtwfRMKBLkMne6udYOmvH0CawotVa7TfgYHzAnpphn4+TweIx1QKMnRIbipmUg== | ||
|
||
[email protected].0: | ||
version "5.31.0" | ||
resolved "https://registry.yarnpkg.com/stream-chat-react-native-core/-/stream-chat-react-native-core-5.31.0.tgz#8bbcd7310891bf70fc8c0ff345224be9d29cd59e" | ||
integrity sha512-gPhY5Ly+n8tfa/awu1hV9+Aj+1c35lUpo+UZLgcmgPey2F7kC8YZr1pvon6m7IWTh/MoU5IEnqtswqF+NWQdBQ== | ||
[email protected].1: | ||
version "5.31.1" | ||
resolved "https://registry.yarnpkg.com/stream-chat-react-native-core/-/stream-chat-react-native-core-5.31.1.tgz#4367276c8316d325e6b062e4efb95d464d4e2eef" | ||
integrity sha512-EKHMQ0bWRoyubTxk1IKEbkIzcIY5hxHDpyGU7ObGXLLnhoVBEDranZBQ7dNDdbuM88uKh9mGK5WH4NQSTioKxQ== | ||
dependencies: | ||
"@gorhom/bottom-sheet" "4.4.8" | ||
dayjs "1.10.5" | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1067,11 +1067,6 @@ | |
dependencies: | ||
"@sinonjs/commons" "^3.0.0" | ||
|
||
"@stream-io/[email protected]": | ||
version "0.10.3" | ||
resolved "https://registry.yarnpkg.com/@stream-io/flat-list-mvcp/-/flat-list-mvcp-0.10.3.tgz#774e56aba7f3da5a8f2ae5ad3065f05e5a27e7f2" | ||
integrity sha512-2ZK8piYlEfKIPZrH8BpZz9uj8HZcUvMCV0X7qSLSAc/vhLOANBfR0SSn0OaWPbqb2mFGAd4FxmLSPp1zKEYuaw== | ||
|
||
"@types/istanbul-lib-coverage@*", "@types/istanbul-lib-coverage@^2.0.0": | ||
version "2.0.4" | ||
resolved "https://registry.yarnpkg.com/@types/istanbul-lib-coverage/-/istanbul-lib-coverage-2.0.4.tgz#8467d4b3c087805d63580480890791277ce35c44" | ||
|
@@ -4237,10 +4232,10 @@ statuses@~1.5.0: | |
resolved "https://registry.yarnpkg.com/statuses/-/statuses-1.5.0.tgz#161c7dac177659fd9811f43771fa99381478628c" | ||
integrity sha512-OpZ3zP+jT1PI7I8nemJX4AKmAX070ZkYPVWV/AaKTJl+tXCTGyVdC1a4SL8RUQYEwk/f34ZX8UTykN68FwrqAA== | ||
|
||
[email protected].0: | ||
version "5.31.0" | ||
resolved "https://registry.yarnpkg.com/stream-chat-react-native-core/-/stream-chat-react-native-core-5.31.0.tgz#8bbcd7310891bf70fc8c0ff345224be9d29cd59e" | ||
integrity sha512-gPhY5Ly+n8tfa/awu1hV9+Aj+1c35lUpo+UZLgcmgPey2F7kC8YZr1pvon6m7IWTh/MoU5IEnqtswqF+NWQdBQ== | ||
[email protected].1: | ||
version "5.31.1" | ||
resolved "https://registry.yarnpkg.com/stream-chat-react-native-core/-/stream-chat-react-native-core-5.31.1.tgz#4367276c8316d325e6b062e4efb95d464d4e2eef" | ||
integrity sha512-EKHMQ0bWRoyubTxk1IKEbkIzcIY5hxHDpyGU7ObGXLLnhoVBEDranZBQ7dNDdbuM88uKh9mGK5WH4NQSTioKxQ== | ||
dependencies: | ||
"@gorhom/bottom-sheet" "4.4.8" | ||
dayjs "1.10.5" | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -1,5 +1,11 @@ | ||||||
import React, { PropsWithChildren, useCallback, useEffect, useMemo, useRef, useState } from 'react'; | ||||||
import { KeyboardAvoidingViewProps, StyleSheet, Text, View } from 'react-native'; | ||||||
import { | ||||||
FlatList as FlatListDefault, | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
this should be possible now right? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No, this is done to assign the name to the prop FlatList below which will be conflicting if same name used. |
||||||
KeyboardAvoidingViewProps, | ||||||
StyleSheet, | ||||||
Text, | ||||||
View, | ||||||
} from 'react-native'; | ||||||
|
||||||
import debounce from 'lodash/debounce'; | ||||||
import throttle from 'lodash/throttle'; | ||||||
|
@@ -74,7 +80,7 @@ import { | |||||
ThumbsUpReaction, | ||||||
WutReaction, | ||||||
} from '../../icons'; | ||||||
import { FlatList as FlatListDefault, pickDocument } from '../../native'; | ||||||
import { pickDocument } from '../../native'; | ||||||
import * as dbApi from '../../store/apis'; | ||||||
import type { DefaultStreamChatGenerics } from '../../types/types'; | ||||||
import { addReactionToLocalState } from '../../utils/addReactionToLocalState'; | ||||||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you missed a very important change here! and this should be done in core
also in expo , the relevant expo version of 0.72 and above must be set
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also we should update the compatibility table in the installation docs or add a note
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was planning to do this in a separate PR since it will be easy for me to track and update the changes.