Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show user reactions in threads #2814

Merged
merged 2 commits into from
Nov 27, 2024
Merged

Conversation

khushal87
Copy link
Member

@khushal87 khushal87 commented Nov 26, 2024

The goal of the PR is to show the reactions in the Thread messages, which were buggy previously and were not displayed.

@Stream-SDK-Bot
Copy link
Contributor

Stream-SDK-Bot commented Nov 26, 2024

SDK Size

title develop branch diff status
js_bundle_size 452 KB 452 KB 0 B 🟢

Copy link
Contributor

@isekovanic isekovanic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me ! Can you please leave a comment or a TODO somewhere that currently threads are not supported for the offline usecase and that this will change in the future ?

@khushal87
Copy link
Member Author

Looks good to me ! Can you please leave a comment or a TODO somewhere that currently threads are not supported for the offline usecase and that this will change in the future ?

Done

@khushal87 khushal87 merged commit 837c2d2 into develop Nov 27, 2024
7 checks passed
@khushal87 khushal87 deleted the fix-reactions-in-thread branch November 27, 2024 04:58
@github-actions github-actions bot mentioned this pull request Nov 28, 2024
6 tasks
@stream-ci-bot
Copy link
Contributor

🎉 This PR is included in version 5.43.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants