fix: make channel.visible respect archived and pinned channels
#2633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnautov-anton
force-pushed
the
fix/use-channel-list-shape-improvements
branch
from
119d82f to
3219f4a
Compare
arnautov-anton
force-pushed
the
fix/use-channel-list-shape-improvements
branch
from
3219f4a to
b7b5ce2
Compare
|
Size Change: 0 B Total Size: 1.2 MB ℹ️ View Unchanged
|
arnautov-anton
force-pushed
the
fix/use-channel-list-shape-improvements
branch
2 times, most recently
from
28d4fbf to
2a56266
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2633 +/- ##
==========================================
- Coverage 80.78% 80.76% -0.03%
==========================================
Files 450 450
Lines 9646 9650 +4
Branches 2301 2302 +1
==========================================
+ Hits 7793 7794 +1
- Misses 1733 1736 +3
Partials 120 120 ☔ View full report in Codecov by Sentry. |
arnautov-anton
force-pushed
the
fix/use-channel-list-shape-improvements
branch
from
2a56266 to
1c7639a
Compare
isekovanic
reviewed
Feb 5, 2025
| type: event.channel.type, | ||
| }); | ||
|
|
||
| const considerArchivedChannels = shouldConsiderArchivedChannels(filters); |
There was a problem hiding this comment.
Ah, I think I missed this bit - I could it could happen that a channel is archived and hidden so making it visible should respect the archive first, right ?
There was a problem hiding this comment.
I mean - realistically this should never happen but it's there to respect the filter value in case it ever happens (whatever the actual integration looks like). I just copied and slightly adjusted the notification.message_new handler.
There was a problem hiding this comment.
No no, it's totally on point - I just missed it when doing the fixes 👍
isekovanic
approved these changes
Feb 6, 2025
There was a problem hiding this comment.
Looks good ! Don't forget to remove this if you intended to do so (or this can happen once we merge the LLC PR too)
arnautov-anton
force-pushed
the
fix/use-channel-list-shape-improvements
branch
from
1c7639a to
cc4a24d
Compare
arnautov-anton
force-pushed
the
fix/use-channel-list-shape-improvements
branch
from
cc4a24d to
ab98d77
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Feb 7, 2025
## [12.11.0](v12.10.0...v12.11.0) (2025-02-07) ### Bug Fixes * change useStateStore to use useSyncExternalStore ([#2573](#2573)) ([6f2de4e](6f2de4e)) * make `channel.visible` respect archived and pinned channels ([#2633](#2633)) ([2d2e2e5](2d2e2e5)) ### Features * allow custom ReactionsListModal ([#2632](#2632)) ([a428dc9](a428dc9)) * allow to search for channels only ([#2625](#2625)) ([a4d6d83](a4d6d83)) ### Chores * **deps:** upgrade @stream-io/stream-chat-css to version 5.7.0 ([#2636](#2636)) ([8b7cfba](8b7cfba))
|
🎉 This PR is included in version 12.11.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
References: GetStream/stream-chat-react-native#2925