Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix user mention not tappable when contains "@" character #2928

Merged
merged 5 commits into from
Dec 8, 2023
Merged

Fix user mention not tappable when contains "@" character #2928

merged 5 commits into from
Dec 8, 2023

Conversation

nuno-vieira
Copy link
Member

@nuno-vieira nuno-vieira commented Dec 7, 2023 •
edited
Loading

🔗 Issue Links

Resolves https://github.com/GetStream/ios-issues-tracking/issues/665

🎯 Goal

Fix user mention not tappable when contains "@" character.
Bonus: Fix user mention not tappable if user does not have a name

🧪 Manual Testing Notes

  1. Mention a user that contains a special "@" character
  2. Tap on that user
  3. It should log that "showUser" was called

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change follows zero ⚠️ policy (required)
  • This change should be manually QAed
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (docusaurus, tutorial, CMS)

@nuno-vieira nuno-vieira added 🐞 Bug An issue or PR related to a bug 🎨 SDK: StreamChatUI Tasks related to the StreamChatUI SDK labels Dec 7, 2023
@nuno-vieira nuno-vieira requested a review from a team as a code owner December 7, 2023 18:12
martinmitrevski
martinmitrevski approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@martinmitrevski martinmitrevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅ Changelog needs updating though

@nuno-vieira nuno-vieira merged commit 3272885 into develop Dec 8, 2023
3 checks passed
@nuno-vieira nuno-vieira deleted the fix/user-mention-with-@-not-tappable branch December 8, 2023 13:15
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 45 Code Smells

90.8% 90.8% Coverage
0.0% 0.0% Duplication

@testableapple testableapple mentioned this pull request Dec 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@opfeffer opfeffer opfeffer left review comments

@martinmitrevski martinmitrevski martinmitrevski approved these changes

Assignees
No one assigned
Labels
🐞 Bug An issue or PR related to a bug 🎨 SDK: StreamChatUI Tasks related to the StreamChatUI SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nuno-vieira @opfeffer @martinmitrevski