Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicated Runpath Search Paths #2937

Merged
merged 2 commits into from
Dec 14, 2023

Conversation

nuno-vieira
Copy link
Member

@nuno-vieira nuno-vieira commented Dec 14, 2023

🔗 Issue Links

#2936

🎯 Goal

Fixes duplicated Runpath Search Paths. This was causing compilation warnings in Xcode 15, which has a new linker implementation, and it looks like it does not strip duplicated search paths. Either way, we can fix this on our side, and make sure we do not have duplicated search paths.

🛠 Implementation

The reason we had duplicated search paths, was that we had both @executable_path/Frameworks and @loader_path/Frameworks defined in the Xcode project, and also in the StreamChat and StreamChatUI build settings. We had the search paths defined in the build settings of the frameworks plus the "$(inherited)" which basically copies what is defined in the Xcode project, hence the duplication. In our case, we can simply just use the $(inherited) and it will inherit the search parths from the Xcode project, there's no need to type them again in the frameworks.

🎨 Showcase

Before After
image image
image image

🧪 Manual Testing Notes

  • Generate XCFrameworks and link against a project

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change follows zero ⚠️ policy (required)
  • This change should be manually QAed
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (docusaurus, tutorial, CMS)

@nuno-vieira nuno-vieira added the 🐞 Bug An issue or PR related to a bug label Dec 14, 2023
@nuno-vieira nuno-vieira requested a review from a team as a code owner December 14, 2023 15:01
@nuno-vieira nuno-vieira enabled auto-merge (squash) December 14, 2023 15:22
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

47 New issues
0 Security Hotspots
90.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@nuno-vieira nuno-vieira merged commit 77b3dbb into develop Dec 14, 2023
15 checks passed
@nuno-vieira nuno-vieira deleted the fix/duplicated-search-paths-warnings branch December 14, 2023 16:44
This was referenced Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 Bug An issue or PR related to a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants