Fix duplicated Runpath Search Paths #2937
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Links
#2936
🎯 Goal
Fixes duplicated Runpath Search Paths. This was causing compilation warnings in Xcode 15, which has a new linker implementation, and it looks like it does not strip duplicated search paths. Either way, we can fix this on our side, and make sure we do not have duplicated search paths.
🛠 Implementation
The reason we had duplicated search paths, was that we had both
@executable_path/Frameworks
and@loader_path/Frameworks
defined in the Xcode project, and also in theStreamChat
andStreamChatUI
build settings. We had the search paths defined in the build settings of the frameworks plus the "$(inherited)" which basically copies what is defined in the Xcode project, hence the duplication. In our case, we can simply just use the$(inherited)
and it will inherit the search parths from the Xcode project, there's no need to type them again in the frameworks.🎨 Showcase
🧪 Manual Testing Notes
☑️ Contributor Checklist