Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CocoaPods linting error #3558

Merged
merged 1 commit into from
Jan 14, 2025
Merged

CocoaPods linting error #3558

merged 1 commit into from
Jan 14, 2025

Conversation

laevandus
Copy link
Contributor

🔗 Issue Links

Provide all Linear and/or Github issues related to this PR, if applicable.

🎯 Goal

Describe why we are making this change.

📝 Summary

Provide bullet points with the most important changes in the codebase.

🛠 Implementation

Provide a detailed description of the implementation and explain your decisions if you find them relevant.

🎨 Showcase

Add relevant screenshots and/or videos/gifs to easily see what this PR changes, if applicable.

Before After
img img

🧪 Manual Testing Notes

Explain how this change can be tested manually, if applicable.

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change should be manually QAed
  • Changelog is updated with client-facing changes
  • Changelog is updated with new localization keys
  • New code is covered by unit tests
  • Documentation has been updated in the docs-content repo

@laevandus laevandus added the 🤖 CI/CD Any work related to CI/CD label Jan 14, 2025
@laevandus laevandus requested a review from a team as a code owner January 14, 2025 13:12
import Foundation
import MobileCoreServices
Copy link
Contributor Author

@laevandus laevandus Jan 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pod lint is met with AppSettings.swift:6:8: error: no such module 'MobileCoreServices', but with CoreServices it is OK (reproduce the issue locally and verified the fix).

@laevandus laevandus enabled auto-merge (squash) January 14, 2025 13:17
Copy link

1 Warning
⚠️ Please be sure to complete the Contributor Checklist in the Pull Request description
1 Message
📖 There seems to be app changes but CHANGELOG wasn't modified.
Please include an entry if the PR includes user-facing changes.
You can find it at CHANGELOG.md.

Generated by 🚫 Danger

@Stream-SDK-Bot
Copy link
Collaborator

SDK Size

title develop branch diff status
StreamChat 7.0 MB 7.0 MB 0 KB 🟢
StreamChatUI 4.77 MB 4.77 MB 0 KB 🟢

@Stream-SDK-Bot
Copy link
Collaborator

SDK Performance

target metric benchmark branch performance status
MessageList Hitches total duration 10 ms 6.68 ms 33.2% 🔼 🟢
Duration 2.6 s 2.54 s 2.31% 🔼 🟢
Hitch time ratio 4 ms per s 2.63 ms per s 34.25% 🔼 🟢
Frame rate 75 fps 78.37 fps 4.49% 🔼 🟢
Number of hitches 1 0.8 20.0% 🔼 🟢

@laevandus laevandus merged commit e8648f5 into develop Jan 14, 2025
15 checks passed
@laevandus laevandus deleted the ci/pod-lib-lint-error branch January 14, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 CI/CD Any work related to CI/CD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants