Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove internal _isDatabaseObserverItemReusingEnabled runtime check #3562

Merged
merged 3 commits into from
Jan 17, 2025

Conversation

laevandus
Copy link
Contributor

🔗 Issue Links

N/A

🎯 Goal

Remove internal _isDatabaseObserverItemReusingEnabled which has been enabled for 6 months without any side-effects

🧪 Manual Testing Notes

N/A

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change should be manually QAed
  • Changelog is updated with client-facing changes
  • Changelog is updated with new localization keys
  • New code is covered by unit tests
  • Documentation has been updated in the docs-content repo

@laevandus laevandus added the 🌐 SDK: StreamChat (LLC) Tasks related to the StreamChat LLC SDK label Jan 16, 2025
@laevandus laevandus requested a review from a team as a code owner January 16, 2025 08:24
Copy link

1 Message
📖 There seems to be app changes but CHANGELOG wasn't modified.
Please include an entry if the PR includes user-facing changes.
You can find it at CHANGELOG.md.

Generated by 🚫 Danger

@Stream-SDK-Bot
Copy link
Collaborator

SDK Size

title develop branch diff status
StreamChat 7.0 MB 7.0 MB -1 KB 🚀
StreamChatUI 4.77 MB 4.77 MB 0 KB 🟢

@Stream-SDK-Bot
Copy link
Collaborator

SDK Performance

target metric benchmark branch performance status
MessageList Hitches total duration 10 ms 6.68 ms 33.2% 🔼 🟢
Duration 2.6 s 2.55 s 1.92% 🔼 🟢
Hitch time ratio 4 ms per s 2.63 ms per s 34.25% 🔼 🟢
Frame rate 75 fps 78.92 fps 5.23% 🔼 🟢
Number of hitches 1 0.8 20.0% 🔼 🟢

@Stream-SDK-Bot
Copy link
Collaborator

Stream-SDK-Bot commented Jan 16, 2025

SDK Size

title develop branch diff status
StreamChat 7.0 MB 7.0 MB -1 KB 🚀
StreamChatUI 4.77 MB 4.77 MB 0 KB 🟢

@laevandus laevandus merged commit 5624d53 into develop Jan 17, 2025
14 checks passed
@laevandus laevandus deleted the cleanup/model-reuse-runtime-check branch January 17, 2025 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌐 SDK: StreamChat (LLC) Tasks related to the StreamChat LLC SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants