Add simpler way to customize header and footer views in the Message List #3567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s and next messages in the Channel
SDK Size
|
SDK Performance
|
SDK Size
|
| // Example of custom header views. | ||
| // The same code should be provided to `ChatThreadVC` if you want the same behaviour in threads. | ||
|
|
||
| lazy var messageListHeaderView: UIView? = { |
There was a problem hiding this comment.
maybe the loading indicator is enough for the showcase? I think we should keep the sample app as clean as possible, and this label is not very common for messaging apps.
There was a problem hiding this comment.
We can explain in the docs the channelController.hasLoadedAllPreviousMessages, customers here would usually show some custom UI.
There was a problem hiding this comment.
Yeah, I was planning on adding docs. So yeah maybe the "Loaded all messages" we can do it only for the docs 👍
laevandus
approved these changes
Jan 21, 2025
martinmitrevski
approved these changes
Jan 21, 2025
…s-to-message-list
nuno-vieira
deleted the
add/simpler-way-to-add-headers-and-footers-to-message-list
branch
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Links
Resolves https://linear.app/stream/issue/IOS-450/
Resolves https://linear.app/stream/issue/IOS-560/
🎯 Goal
📝 Summary
ChatMessageListVC.headerView+ChatMessageListVC.footerViewChatChannelVC.loadPreviousMessages()+ChatChannelVC.didFinishLoadingPreviousMessages(error:)ChatChannelVC.loadNextMessages()+ChatChannelVC.didFinishLoadingNextMessages(error:)ChatThreadVC.loadPreviousReplies()+ChatThreadVC.didFinishLoadingPreviousReplies(error:)ChatThreadVC.loadNextReplies()+ChatThreadVC.didFinishLoadingNextReplies(error:)🛠 Implementation
Header + Footer
The
ChatMessageListVC.headerViewandChatMessageListVC.footerViewinternally account for the fact that the table view is inverted, so the views are automatically mirrored and set the header as footer and vice-versa.Customizing loading views
Since the header and footer views are commonly used to render loading views, it made sense to merge 2 tickets into this PR.
This PR makes it easier to handle state management when loading more messages/replies in either the Channel or the Thread.
🧪 Manual Testing Notes
A simple loading view indicator was added when loading more messages in the Demo App:
☑️ Contributor Checklist
docs-contentrepo