-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4.71.0 Release #3572
Merged
Merged
4.71.0 Release #3572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
β¦ist (#3567) * Add `ChatMessageListVC.headerView` and `ChatMessageListVC.footerView` * Expose open functions to be able do manage state when loading previous and next messages in the Channel * Expose similar functions in the Thread View * Provide an example in the demo app * Fix calling didFinishSync instead of loading next messages * Simplify code * Fix typos * Add loading indicator view to DemoChatThreadVC * Add test coverage to header and footer views * Update CHANGELOG.md * Fix UI Tests * Remove custom header from Demo App
* Enable CoreData Concurrency Thread Safety Flag in StreamDevelopers Scheme * Do not use chat client config from CoreData when creating the MessageController * Make accessing ChatClientConfig in the Database Layer safer * Fix unit tests * Update CHANGELOG.md * Update CHANGELOG.md * Fix typo * Fix chat client config tests not passing
* Add transformer closures to be able to map stream models * Refactor to a protocol instead of closures * Rename mapped -> replacing * Update Sources/StreamChat/Config/StreamModelsTransformer.swift Co-authored-by: Toomas Vahter <[email protected]> * Add additional comment * Use transformer directly from context * Remove unnecessary DataStore.chatClient ref * Provide documentation to the `replacing()` function * Update transformed data * Add test coverage to ChatChannel.replacing and ChatMessage.replacing * Add test coverage to creating a new message with transformable data * Add test coverage to creating a new reply with transformable data * Add test coverage that DTOs are transformed * Allow transforming members * Add test coverage to channel member transformation * Update CHANGELOG.md * Update CHANGELOG.md * Update CHANGELOG.md * Add Member Dummy Transformation example * Better be safe than sorry (Never trust CoreData :D) --------- Co-authored-by: Toomas Vahter <[email protected]>
β¦3568) * Fix reaction author's view with shrinked reaction images * Fix missing recording snapshots * Update CHANGELOG.md
* Dismiss thread when hard deleting root message * Fix duplicated `didReceiveEvent` inside `ChatThreadVC` This was caused by setting 2 event delegates, one for channel events and another one for regular events * Fix hard-deleted message events not surfacing to the `EventsController` This was because when hard deleting a message it disappears from CoreData, so we can't create the Event domain model with the message model. So for this I created a different event. * Expose `Event.name` * Use the Event in the Demo App instead of assuming that message == nil is because the message was hard deleted * Make sure the root message does not disappear * Update CHANGELOG.md * Update CHANGELOG.md * Update CHANGELOG.md * Add test coverage * Update DemoApp/StreamChat/Components/DemoChatThreadVC.swift Co-authored-by: Toomas Vahter <[email protected]> * Change the approach: Do not create a new event for Hard Deleted * Remove unused code * Add isSentByCurrentUser logic to hard deleted message * Fix replies from hard deleted message not deleted * Update CHANGELOG.md * Simplify DemoApp example --------- Co-authored-by: Toomas Vahter <[email protected]>
SDK Size
|
Generated by π« Danger |
Build for regression testing β123457051 has been uploaded to TestFlight π |
SDK Performance
|
|
testableapple
approved these changes
Jan 28, 2025
/merge release |
Publication of the release has been launched π |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StreamChat
β Added
Event.name
to easily check which event it is #3569π Fixed
connectUser()
methods can sometimes throwCurrentUserDoesNotExist()
unexpectedly #3565ChatClientConfig.modelsTransformer
ChatMessage.replacing()
ChatChannel.replacing()
ChatChannelMember.replacing()
EventsController
#3569StreamChatUI
β Added
ChatMessageListVC.headerView
ChatMessageListVC.footerView
ChatChannelVC.loadPreviousMessages()
+ChatChannelVC.didFinishLoadingPreviousMessages(error:)
ChatChannelVC.loadNextMessages()
+ChatChannelVC.didFinishLoadingNextMessages(error:)
ChatThreadVC.loadPreviousReplies()
+ChatThreadVC.didFinishLoadingPreviousReplies(error:)
ChatThreadVC.loadNextReplies()
+ChatThreadVC.didFinishLoadingNextReplies(error:)
π Fixed
didReceiveEvent
insideChatThreadVC
#3569π Changed
ChatThreadVC.channelEventsController
#3569