Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editing quoted messages did not refresh the message list #536

Merged
merged 2 commits into from
Jul 8, 2024
Merged

Editing quoted messages did not refresh the message list #536

merged 2 commits into from
Jul 8, 2024

Conversation

laevandus
Copy link
Contributor

@laevandus laevandus commented Jul 4, 2024 •
edited
Loading

🔗 Issue Link

Related PBE-4291

🎯 Goal

Redisplay quoted message after edit.

🛠 Implementation

Disable caching and use LLC's ChatMessage equality changes.

🧪 Testing

  1. Send a message
  2. Quote the sent message
  3. Edit the initial message > second message redisplays

🎨 Changes

Before After
img img

☑️ Checklist

  • I have signed the Stream CLA (required)
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Affected documentation updated (docusaurus, tutorial, CMS (task created)

@laevandus laevandus requested a review from a team as a code owner July 4, 2024 08:29
@laevandus laevandus added bug Something isn't working swiftui-repo labels Jul 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 4, 2024

1 Message
📖 There seems to be app changes but CHANGELOG wasn't modified.
Please include an entry if the PR includes user-facing changes.
You can find it at CHANGELOG.md.

Generated by 🚫 Danger

@laevandus laevandus marked this pull request as draft July 4, 2024 10:01
@laevandus laevandus force-pushed the fix/editing-quoted-message branch from d005d3a to 375fd44 Compare July 4, 2024 10:09
martinmitrevski
martinmitrevski approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@martinmitrevski martinmitrevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this, let's merge it as soon as we merge it in the LLC and update the branch here.

@laevandus laevandus marked this pull request as ready for review July 8, 2024 13:15
@laevandus laevandus force-pushed the fix/editing-quoted-message branch from 210a681 to c6b3a3b Compare July 8, 2024 13:16
@laevandus laevandus enabled auto-merge (squash) July 8, 2024 13:18
@laevandus laevandus force-pushed the fix/editing-quoted-message branch from c6b3a3b to b3bc28f Compare July 8, 2024 14:07
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jul 8, 2024

Quality Gate Passed Quality Gate passed

Issues
88 New issues
0 Accepted issues

Measures
0 Security Hotspots
72.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@laevandus laevandus merged commit 96c679f into develop Jul 8, 2024
10 checks passed
@laevandus laevandus deleted the fix/editing-quoted-message branch July 8, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinmitrevski martinmitrevski martinmitrevski approved these changes

Assignees
No one assigned
Labels
bug Something isn't working swiftui-repo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@laevandus @martinmitrevski