Styled markdown with AttributedString #757
Conversation
| branch = "feature/attributed-string-styled-markdown"; | ||
| kind = branch; |
There was a problem hiding this comment.
Change it before merge
Generated by 🚫 Danger |
| Group { | ||
| if let displayedText { | ||
| Text(displayedText) | ||
| } else if markdownEnabled { | ||
| Text(text) | ||
| } else { | ||
| Text(message.adjustedText) | ||
| } |
There was a problem hiding this comment.
This file's diff is pretty unreadable.
Before
- Manual link detection for mentions and plain links was separate from markdown handling
- Markdown handling came purely from Text's markdown support
After
- First parse and style markdown (if allowed)
- Add links for mentions (if allowed)
- Detect plain links in text (if allowed)
- Apply styling attributes for links
Some things could be improved further: since now we use AttributedString always, then it could be created in init (onAppear feels unnecessary, but removing it does break tint color). Needs some investigation (probably better to be a separate PR).
| var linkAttributeContainer = AttributeContainer() | ||
| if let uiColor = linkAttributes[.foregroundColor] as? UIColor { | ||
| linkAttributeContainer = linkAttributeContainer.foregroundColor(Color(uiColor: uiColor)) | ||
| linkAttributes.removeValue(forKey: .foregroundColor) | ||
| } | ||
| linkAttributeContainer.merge(AttributeContainer(linkAttributes)) |
There was a problem hiding this comment.
Slightly messy because I need to make sure SwiftUIAttributes.ForegroundColor is used if UIColor is passed in from messageLinkDisplayResolver. Only way I found it make it working is init attributes without UIColor and then adding Color to the container using the .foregroundColor() functions which takes in a Color instance.
SDK Size
|
..._Snapshots__/MessageView_Tests/test_markdown_mixedLists_nested.rightToLeftLayout-default.png
Outdated
Show resolved
Hide resolved
|
🔗 Issue Link
Resolves: IOS-41
🎯 Goal
Use AttributedString's markdown parsing support with additional styling.
🛠 Implementation
MarkdownParserfor styling the finalAttributedStringLinkDetectionTextViewand then apply mentions and plain link detection🧪 Testing
@username,@userid) + plain links🎨 Changes
☑️ Checklist