fix: improved error handling when connecting to an SFU (#1648)

Make sure we bubble the potential errors coming out of the initial SFU signal server connection establishment. --------- Co-authored-by: Matvei Andrienko <[email protected]>
GetStream · Jan 20, 2025 · 27332b4 · 27332b4
1 parent 2e258a1
commit 27332b4
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/packages/client/src/StreamSfuClient.ts b/packages/client/src/StreamSfuClient.ts
@@ -227,16 +227,23 @@ export class StreamSfuClient {
       },
     });
 
-    this.signalWs.addEventListener('close', this.handleWebSocketClose);
-
     this.signalReady = makeSafePromise(
       Promise.race<WebSocket>([
-        new Promise((resolve) => {
+        new Promise((resolve, reject) => {
           const onOpen = () => {
             this.signalWs.removeEventListener('open', onOpen);
             resolve(this.signalWs);
           };
+
           this.signalWs.addEventListener('open', onOpen);
+
+          this.signalWs.addEventListener('close', () => {
+            this.handleWebSocketClose();
+            // Normally, this shouldn't have any effect, because WS should never emit 'close'
+            // before emitting 'open'. However, strager things have happened, and we don't
+            // want to leave signalReady in pending state.
+            reject(new Error('SFU WS closed unexpectedly'));
+          });
         }),
 
         new Promise((resolve, reject) => {

diff --git a/packages/client/src/rtc/signal.ts b/packages/client/src/rtc/signal.ts
@@ -9,6 +9,7 @@ export const createWebSocketSignalChannel = (opts: {
 }) => {
   const { endpoint, onMessage, logTag } = opts;
   const logger = getLogger(['SfuClientWS', logTag]);
+  logger('debug', 'Creating signaling WS channel:', endpoint);
   const ws = new WebSocket(endpoint);
   ws.binaryType = 'arraybuffer'; // do we need this?