Change tag-it to tagify and upgrade bootstrap #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just sorting out the allowSpaces option, tagify has some weird options around that. |
NathanBeddoeWebDev
force-pushed
the
master
branch
from
875c61c to
2bcdff8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #18
Our team wants to be able to use Geta Tags for our site, but we don't want to reintroduce Jquery. tag-it looks like it's recently deprecated in favor of tagify which is a jquery-less solution. Bootstrap has also removed jquery in version 5, thus I believe we can remove Jquery from Geta Tags.
Note
Just a heads up, I've never developed Episerver widgets or UI components before and I'm not super competent with either Dojo or AMD modules.
One part where this is apparent is where I'm loading cdn scripts directly into our define dependencies. I did originally have something like "Geta.Optimizely.Tags/1.0.0/ClientResources/vendor/tagify.min.js" which was working in development, but I don't think it was going to work when I packed it with a proper version. If you've got a better way to load vendor scripts into AMD, I'm all ears.
Utilizes https://github.com/yairEO/dragsort and https://github.com/yairEO/tagify