Don't send softEnumPackets when command suggestions are false #4037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tem property to not send team suggestions
Konicai
reviewed
Aug 6, 2023
core/src/main/java/org/geysermc/geyser/scoreboard/Scoreboard.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/geysermc/geyser/session/GeyserSession.java
Outdated
Show resolved
Hide resolved
Camotoy
approved these changes
Aug 6, 2023
Konicai
approved these changes
Aug 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally to the above, this adds a system property (
-DGeyser.AddTeamSuggestions) so this behavior can be set to false in cases where you still want command suggestions, just without teams being suggested (e.g. in the case where too many teams exist). Could yeet the property again if it's deemed not worthy to account for this one edge-case.Thanks camo for the assist :)
Fixes #3929