Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom unusable-space blocker item #4038

Merged
merged 3 commits into from
Aug 7, 2023

Conversation

onebeastchris
Copy link
Member

This change would allow the specifying of a custom item (aka via custom model data) by specifying the Bedrock custom identifier ( as suggested in #3512 (comment).)

A few changes/issues:

  • since there doesn't appear to be a clean method to get item definitions by their bedrock identifier (there is one for java, not bedrock), a loop through all the items until the item with the Bedrock identifier is needed
  • the namespace needs to be specified too; so something like
    unusable-space-block: "geyser_custom:my_item" would be needed.

Fixes #3512

@Kas-tle Kas-tle merged commit b1f04a9 into GeyserMC:master Aug 7, 2023
1 check passed
@onebeastchris onebeastchris deleted the unusable-space-block branch December 1, 2023 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allow custom unusable-space-block
2 participants