Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update DeviceOs to latest protocol #4553

Merged
merged 3 commits into from
Jul 23, 2024
Merged

Update DeviceOs to latest protocol #4553

merged 3 commits into from
Jul 23, 2024

Conversation

rtm516
Copy link
Member

@rtm516 rtm516 commented Apr 7, 2024 •
edited
Loading

Updated to follow the newly published protocol specification. Will probably need a floodgate update aswell.

https://github.com/CloudburstMC/protocol-docs/blob/master/enums/BuildPlatform.md

We likely want to merge GeyserMC/api#4 first

@rtm516 rtm516 added the PR: Cosmetic When a PR adds something that is purely cosmetic, like changing the README label Apr 7, 2024
onebeastchris
onebeastchris approved these changes Apr 7, 2024
View reviewed changes
Copy link
Member

@onebeastchris onebeastchris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this will likely need a new Floodgate build

Tim203
Tim203 requested changes Apr 7, 2024
View reviewed changes
Copy link
Member

@Tim203 Tim203 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't mark them as deprecated instead I'd add it in a comment saying that those platforms are no longer in use.
Deprecated would indicate to me that they will be removed in the future, but I don't think they'd do that because it'd shift the enum values.

@rtm516
Copy link
Member Author

rtm516 commented Apr 7, 2024 •
edited
Loading

I wouldn't mark them as deprecated instead I'd add it in a comment saying that those platforms are no longer in use. Deprecated would indicate to me that they will be removed in the future, but I don't think they'd do that because it'd shift the enum values.

They removed Hololens from the docs but left the gap in the enum values so I think deprecated is good, for this. They also marked the others as deprecated. If they add more they could replace the old values.

@onebeastchris onebeastchris changed the base branch from master to api/2.4.1 July 16, 2024 00:17
@onebeastchris onebeastchris merged commit 81aedf1 into GeyserMC:api/2.4.1 Jul 23, 2024
2 checks passed
@rtm516 rtm516 deleted the fix/deviceos branch July 25, 2024 11:23
Konicai pushed a commit that referenced this pull request Aug 1, 2024
@rtm516 @Konicai
Update DeviceOs to latest protocol (#4553)
03187b6 
* Update DeviceOs to latest protocol
* Revert enum name change and add deprecation annotations
XingLingQAQ pushed a commit to XingLingQAQ/Geyser that referenced this pull request Sep 25, 2024
@rtm516 @XingLingQAQ
Update DeviceOs to latest protocol (GeyserMC#4553)
6901ad8 
* Update DeviceOs to latest protocol
* Revert enum name change and add deprecation annotations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tim203 Tim203 Tim203 approved these changes

@Camotoy Camotoy Camotoy approved these changes

@Redned235 Redned235 Redned235 approved these changes

@onebeastchris onebeastchris onebeastchris approved these changes

Assignees
No one assigned
Labels
PR: Cosmetic When a PR adds something that is purely cosmetic, like changing the README
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rtm516 @Tim203 @Camotoy @Redned235 @onebeastchris