1.20.80 Support and Protocol Changes #4561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joshua Castle <[email protected]>
Signed-off-by: Joshua Castle <[email protected]>
Signed-off-by: Joshua Castle <[email protected]>
Signed-off-by: Joshua Castle <[email protected]>
Signed-off-by: Joshua Castle <[email protected]>
Signed-off-by: Joshua Castle <[email protected]>
onebeastchris
approved these changes
Apr 12, 2024
core/src/main/java/org/geysermc/geyser/network/GameProtocol.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/geysermc/geyser/network/GeyserServerInitializer.java
Outdated
Show resolved
Hide resolved
| @@ -173,7 +173,7 @@ private static RecipeData getCraftingDataFromJsonNode(JsonNode node, Int2ObjectM | |||
| /* Convert end */ | |||
|
|
|||
| return ShapedRecipeData.shaped(uuid.toString(), shape.get(0).length(), shape.size(), | |||
| inputs.stream().map(ItemDescriptorWithCount::fromItem).toList(), Collections.singletonList(output), uuid, "crafting_table", 0, netId); | |||
| inputs.stream().map(ItemDescriptorWithCount::fromItem).toList(), Collections.singletonList(output), uuid, "crafting_table", 0, netId, true); | |||
There was a problem hiding this comment.
I wonder if we should make this false -
might resolve this issue:
#4103
Kas-tle
added
the
PR: Needs Testing
Kas-tle
removed
the
PR: Needs Testing
|
Hey! I did some testing myself and have found that any time a boss bar is sent to a Bedrock client, they are kicked with the following error: Edit: Another issue with a similar error when trying to emote to use offhand https://mclo.gs/ArbPXpp |
|
Thank you for testing I appreciate it! |
Kas-tle
added
the
PR: Needs Testing
Signed-off-by: Joshua Castle <[email protected]>
Signed-off-by: Joshua Castle <[email protected]>
|
@ItzFlipp the latest build should fix those two. |
Thank you! Here's one more that we've stumbled across: |
…sEventPacket Signed-off-by: Joshua Castle <[email protected]>
|
Updated for that as well. |
Signed-off-by: Joshua Castle <[email protected]>
Signed-off-by: Joshua Castle <[email protected]>
Signed-off-by: Joshua Castle <[email protected]>
Signed-off-by: Joshua Castle <[email protected]>
Signed-off-by: Joshua Castle <[email protected]>
Signed-off-by: Joshua Castle <[email protected]>
core/src/main/java/org/geysermc/geyser/network/GameProtocol.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Joshua Castle <[email protected]>
Signed-off-by: Joshua Castle <[email protected]>
Signed-off-by: Joshua Castle <[email protected]>
XingLingQAQ
pushed a commit
to XingLingQAQ/Geyser
that referenced
this pull request
Sep 25, 2024
* Make evil more harder Signed-off-by: Joshua Castle <[email protected]> * Deregister more unused packets Signed-off-by: Joshua Castle <[email protected]> * Add more unused packets Signed-off-by: Joshua Castle <[email protected]> * Pin protocol to 68dc192 * Correction * Update Protocol * More kicking Signed-off-by: Joshua Castle <[email protected]> * stop reading when there is no item to read (#9) * Bump protocol Signed-off-by: Joshua Castle <[email protected]> * 1.20.80 Signed-off-by: Joshua Castle <[email protected]> * Remove unused postinitchannel GeyserServerInitializer * Pull protocol jitpack from cloudburst again * Actually builds Signed-off-by: Joshua Castle <[email protected]> * Bump protocol to fix BossEventPacket & EmotePacket Signed-off-by: Joshua Castle <[email protected]> * Add remove before merge comment Signed-off-by: Joshua Castle <[email protected]> * Bump protocol to fix BlockEntityDataPacket and ignore serverbound BossEventPacket Signed-off-by: Joshua Castle <[email protected]> * Bump protocol & add more illegal/ignored packets Signed-off-by: Joshua Castle <[email protected]> * Remove deprecated packet Signed-off-by: Joshua Castle <[email protected]> * Ignore ClientCacheStatusPacket instead of disallow Signed-off-by: Joshua Castle <[email protected]> * Define static serializers Signed-off-by: Joshua Castle <[email protected]> * Less static class nonsense more correct order Signed-off-by: Joshua Castle <[email protected]> * Remove unused import Signed-off-by: Joshua Castle <[email protected]> * Bump protocol Signed-off-by: Joshua Castle <[email protected]> * Move codec processing to CodecProcessor Signed-off-by: Joshua Castle <[email protected]> * Falsify recipe symetry assumption Signed-off-by: Joshua Castle <[email protected]> * Update Protocol for 2 wrong packet IDs & 5 wrong directions * Jitpack protocol from Geyser repo --------- Signed-off-by: Joshua Castle <[email protected]> Co-authored-by: chris <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds 1.20.80 support and also uses an updated version of protocol to increase efficency of packet reads.
Protocol is jitpacked for now but will depend on main repo by merge.