Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grammar handler #20

Merged
merged 16 commits into from
Dec 26, 2023
Merged

Grammar handler #20

merged 16 commits into from
Dec 26, 2023

Conversation

Ghost8345
Copy link
Owner

Created a new way of handling List of Non-Terminals.

Now every Non-Terminal has a vector of vector of shared pointers to a Symbol which is the parent class of a Terminal or a Non-Terminal.

@Ghost8345 Ghost8345 self-assigned this Dec 24, 2023
@Ghost8345 Ghost8345 requested review from ZyadSamy, Deffo0 and usefSaeed and removed request for ZyadSamy December 24, 2023 23:09
Copy link
Collaborator

@usefSaeed usefSaeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Work! @Ghost8345
I added some output streams to make the output grammar somewhat more readable and prepared the interface for first and follow computation for each nonterminal
Now I will approve, make a new branch and start working on follow and first sets

@Ghost8345 Ghost8345 requested a review from Deffo0 December 25, 2023 22:18
@ZyadSamy ZyadSamy merged commit 515506c into main Dec 26, 2023
2 checks passed
@ZyadSamy ZyadSamy deleted the Grammar-Handler branch December 26, 2023 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants