-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SPL Support v2 #43
Open
csmarc
wants to merge
32
commits into
main
Choose a base branch
from
SolSupport-mtest
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
SPL Support v2 #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solsupport ytest
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit ede6f85. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution
Sent with 💌 from NxCloud. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added two separate function which have a similar
This pull request introduces several changes to the anchor/programs/gigentic module, focusing on enhancing the service review and payment functionalities, as well as integrating SPL token support. The most important changes include adding constants for review limits, modifying context structures for service reviews, and introducing new contexts for SPL token payments.
Enhancements to service review and payment functionalities:
anchor/programs/gigentic/src/constants.rs: Added constants MAX_REVIEW_LENGTH and MAX_REVIEWS to define limits for reviews.
anchor/programs/gigentic/src/contexts/agent_to_consumer_rating.rs and anchor/programs/gigentic/src/contexts/consumer_to_agent_rating.rs: Removed service account and added constraints to ensure the review account is correctly associated with the signer. [1] [2] [3]
Introduction of SPL token support:
anchor/programs/gigentic/src/contexts/pay_service_spl.rs: Added a new context PayServiceSpl to handle service payments using SPL tokens, including escrow and token transfer logic.
anchor/programs/gigentic/src/contexts/sign_service_spl.rs: Added a new context SignServiceSpl to handle the signing of services and transferring SPL tokens from escrow to the service provider and fee account.
Modifications to existing service initialization and payment contexts:
anchor/programs/gigentic/src/contexts/init_service.rs: Added service_provider_token_account and service_authority accounts to the InitializeService context.
anchor/programs/gigentic/src/contexts/pay_service.rs: Updated the PayService context to include review_no as an instruction parameter and added logic to handle review initialization and escrow details. [1] [2] [3] [4]
These changes collectively enhance the review system, ensure proper association of reviews with accounts, and introduce support for SPL token transactions.