Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PhoneAuthProvider improvement for ios #528

Merged
merged 6 commits into from
Jun 15, 2024
Merged

PhoneAuthProvider improvement for ios #528

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
80ac5aa
FIRAuthUIDelegateProtocol is not available outside of the firebase li…
kristohear Jun 10, 2024
6b24b87
Make delegate optional
kristohear Jun 12, 2024
1e3c733
Proper PhoneAuthProvider fix
kristohear Jun 12, 2024
27c990f
Fixed jvMain also
kristohear Jun 13, 2024
f0d4dcc
Reverted back AuthCredential logic
kristohear Jun 13, 2024
eb45b5d
Merge branch 'master' into master
Reedyuk Jun 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion firebase-auth/src/iosMain/kotlin/dev/gitlive/firebase/auth/credentials.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ actual class PhoneAuthProvider(val ios: FIRPhoneAuthProvider) {
}

actual interface PhoneVerificationProvider {
val delegate: FIRAuthUIDelegateProtocol
val delegate: FIRAuthUIDelegateProtocol?
suspend fun getVerificationCode(): String
}

Expand Down
Loading