Messaging improvements #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nbransby can you review this pr? |
nbransby
reviewed
Jun 18, 2024
firebase-messaging/src/jsMain/kotlin/dev/gitlive/firebase/messaging/messaging.kt
Outdated
Show resolved
Hide resolved
…n-sdk into feat/MessagingImprovements
nbransby
reviewed
Jun 18, 2024
firebase-messaging/src/jsMain/kotlin/dev/gitlive/firebase/messaging/externals/messaging.kt
Outdated
Show resolved
Hide resolved
|
@nbransby it seems that the android tests keep running infinitely while there were already errors. Could you stop it before it keeps running for hours :) |
rebase now and see if it works |
|
Yay tests work now 🎉 |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds some functionality for the messaging framework that is most important in iOS and Android projects. It is only (un)subscribing to topics and retrieving FCM token. Adding more functionality is going to be hard because of the differences between the sdks.
This pr also has 2 very small improvements from my previous PR's.