This repository was archived by the owner on Feb 12, 2023. It is now read-only.
Adding support for TFS collections on Visual Studio. #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot for your efforts! There is just 1 thing I'd like to see different, care for changing that? |
GeertvanHorrik
suggested changes
Aug 23, 2017
| @@ -72,6 +72,15 @@ public void ReturnsValidProject2() | |||
| } | |||
|
|
|||
| [TestCase] | |||
| public void ReturnsValidProject3() | |||
There was a problem hiding this comment.
I think it's better to just refactor ReturnsValidProject into this:
[TestCase("https://CatenaLogic.visualstudio.com/_git/main-repo", "main-repo")]
[TestCase("https://CatenaLogic.visualstudio.com/BigProject/_git/main-repo", "BigProject")]
[TestCase("https://CatenaLogic.visualstudio.com/DefaultCollection/BigProject/_git/main-repo", "BigProject")]
public void ReturnsValidProject(string url, string expectedProjectName)
{
var provider = new VisualStudioTeamServicesProvider();
provider.Initialize(url);
Assert.AreEqual(expectedProjectName, provider.ProjectName);
}
| private static readonly Regex HostingUrlPattern = new Regex(@"(?<url>(?<companyurl>(?:https://)?(?<accountname>([a-zA-Z0-9\-\.]*)?)\.visualstudio\.com/)(?<project>[a-zA-Z0-9\-\.]*)/?_git//?(?<repo>[^/]+))"); | ||
| // Matches the git origin URL, providing named capture groups | ||
| // Example match: https://user.visualstudio.com/DefaultCollection/MyFirstProject/_git/MyFirstRepo | ||
| private static readonly Regex HostingUrlPattern = |
There was a problem hiding this comment.
Nice, never saw regular expressions split up so nicely, well done.
|
Good call on the requested changes. I'm still not used to NUnit. |
GeertvanHorrik
approved these changes
Sep 5, 2017
|
Sorry for the late review, missed notifications. All looks good now, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #173 .
Checklist
Changes proposed in this pull request: