This repository was archived by the owner on Feb 12, 2023. It is now read-only.
Suppress warning for source files that fall under intermediate output path #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }; | ||
| bool success = Linker.Link(PdbFile.GetMetadata("FullPath"), options); | ||
|
|
||
| return success && !Log.HasLoggedErrors; | ||
| } | ||
|
|
||
| private static string AddTrailingSlash(string path) | ||
| { | ||
| return path.EndsWith(Path.DirectorySeparatorChar.ToString()) |
There was a problem hiding this comment.
Technically we could optimize this method by caching the ToString call, but I guess that is premature optimization.
There was a problem hiding this comment.
We also could just do a last char comparison and avoid ToString altogether. But ya, I was going for simple here since we do it just once.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitLink warns when source files aren't discoverable in the git repo since source server support will fail when debugging into that source file. But when these source files are generated by the build, the warnings are not actionable and the developer should already know these won't be available to debug into. The eventual fix for this is SourceLink which can embed such source files into the PDB. So for now, this PR just suppresses the useless and noisy warnings.