Skip to content
This repository was archived by the owner on Feb 12, 2023. It is now read-only.

#155 Resolves repository location based on pdb path #186

Merged
merged 1 commit into from
Jan 15, 2018
Merged

#155 Resolves repository location based on pdb path #186

merged 1 commit into from
Jan 15, 2018

Conversation

AmadeusW
Copy link
Contributor

@AmadeusW AmadeusW commented Jan 15, 2018 •
edited
Loading

Fixes #155

Changes proposed in this pull request:

  • Finds the repo root based on the pdb path. Previously, repo root was resolved based on an arbitrary file, which might have been located outside of the repo, e.g. in the global .nuget cache directory
  • Consolidates code such that there is only one way to resolve repo root and the error message is descriptive and helpful
  • In Readme, explains how repo root is located and explains the -baseDir parameter
  • Also improves the error messages when libgit2sharp fails to initialize.

Checklist

  • I have included examples or tests (improved readme)
  • I have updated the change log (where is it?)
  • I am listed in the CONTRIBUTORS file
  • I have cleaned up the commit history (use rebase and squash)

@AmadeusW
GitTools#155 Resolves repository location based on pdb path
e4c185a 
Locates the git repo based on the location of the pdb rather than of
an arbitrary file in the pdb. Using arbitrary files leads to
unnecessary errors when a file is located outside of the repo.
AArnott
AArnott approved these changes Jan 15, 2018
View reviewed changes
Copy link
Contributor

@AArnott AArnott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@GeertvanHorrik
Copy link
Contributor

Looks really good, thanks!

@GeertvanHorrik GeertvanHorrik merged commit d848908 into GitTools:develop Jan 15, 2018
@GeertvanHorrik
Copy link
Contributor

Just pushed a new alpha build to both NuGet & Chocolatey.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AArnott AArnott AArnott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generated file incorrectly causing GitLink to fail
3 participants
@AmadeusW @GeertvanHorrik @AArnott