F 594 fix stuck event handler queue #598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -67,6 +67,7 @@ const configureAuditLog = app => { | |||
| setAuditLogToFeathersService({ app, serviceName: 'donations' }); | |||
| setAuditLogToFeathersService({ app, serviceName: 'pledgeAdmins' }); | |||
| setAuditLogToFeathersService({ app, serviceName: 'events' }); | |||
| setAuditLogToFeathersService({ app, serviceName: 'emails' }); | |||
There was a problem hiding this comment.
related to #597, we add emails to elastik search it help us to better debug
| @@ -1,5 +1,5 @@ | |||
| const defaultFeatherMongooseOptions = { | |||
| multi: ['patch'], | |||
| multi: ['patch', 'remove'], | |||
There was a problem hiding this comment.
We get an error in this line because we have blocked multiple delete (I saw it when I was reading the logs to fix this bug), so added remove to the whitelist
feathers-giveth/src/blockchain/lib/eventHandlerQueue.js
Lines 26 to 30 in f245076
aminlatifi
changed the title
aminlatifi
requested changes
Aug 25, 2021
| event: event.event, | ||
| transactionHash: event.transactionHash, | ||
| status: event.status, | ||
| transactionIndex: event.transactionIndex, | ||
| logIndex: event.logIndex, | ||
| _id: event._id, | ||
| }); | ||
| const eventInDb = await eventService.get(event._id); | ||
| if (eventInDb === EventStatus.PROCESSED) { |
There was a problem hiding this comment.
It should be eventInDb.status
There was a problem hiding this comment.
@aminlatifi
You are right, changed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have two main problems on #594
Why queue stocks on a job?
I think maybe because rinkbey network or infura, ..., so a job stocks and other jobs cant start, now I check if after two minutes the job process doesn't end, I call done() manually to not block next jobs
Why after restarting the backend, do some jobs process multiple times?
we have some checking, for example, every 15 minutes we check if there is a
Pendingcampaign we add a job to process that event, so when the queue is blocked for 5 hours, in this time we add 20(5hours * 4 times in an hour) jobs to process same event, so when we restart the application and the queue is not blocked anymore, we start to process the same event 20 times, for preventing this before handling event I check the event status in DB to be sure it's notProcessed