-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrating from Autopilot to Ortto #69
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, please test thoroughly before merging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @RamRamez great work
I commented some changes and write some of them here:
- Remove body.sendSegment, the sendEmail field is enough if we just want to know we should send email or not
- Change
schemaValidator.ts
to removesendSegment
andsegment
from schema validators and addemailPayload
field - Change SegmentAndSchemaValidator , remove
segment
, addemailPayload
and define schema for those validators
If you had any question about these items plz DM me to talk about it ASAP
…E_ADDED_OWNER PROJECT_VERIFIED VERIFICATION_FORM_REJECTED PROJECT_UNVERIFIED
…revision Refactor ortto part
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @RamRamez LGTM
#1184