1.21.3 + Neoforge #48
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gjum
reviewed
Dec 23, 2024
common/src/main/java/gjum/minecraft/civ/snitchmod/common/Renderer.java
Outdated
Show resolved
Hide resolved
Gjum
reviewed
Dec 23, 2024
| @@ -119,7 +118,7 @@ private static void renderSnitch(Snitch snitch) { | |||
| // inflate/deflate so the box face isn't obscured by adjacent blocks | |||
| final boolean playerInRange = range.contains(mc.player.position()); | |||
| AABB rangeBox = playerInRange ? range.inflate(-.01) : range.inflate(.01); | |||
| AABB outlineBox = playerInRange ? range.inflate(-.05) : range.inflate(.05); | |||
| AABB outlineBox = playerInRange ? range.inflate(-.01) : range.inflate(.01); | |||
There was a problem hiding this comment.
does this not result in z fighting?
There was a problem hiding this comment.
It didn't for me. It isn't really necessary though, it just always bothered me to have the box that much smaller than the lines.
Gjum
reviewed
Dec 23, 2024
forge/src/main/java/gjum/minecraft/civ/snitchmod/forge/mixins/LevelRenderMixin.java
Outdated
Show resolved
Hide resolved
Gjum
reviewed
Dec 23, 2024
| import org.spongepowered.asm.mixin.injection.callback.CallbackInfo; | ||
|
|
||
| @Mixin(LevelRenderer.class) | ||
| public abstract class LevelRenderMixin { // REMINDER: Forge sucks |
There was a problem hiding this comment.
would it make sense to use this mixin with all mod loaders? to reduce disparities which may lead to different behavior on different loaders
There was a problem hiding this comment.
We could but the mixin is currently just replicating the behaviour provided by the other loaders because Forge removed the event without a replacement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plus a few other things