Add explainers, and minor datastore implements #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucioMelito
reviewed
Feb 18, 2022
There was a problem hiding this comment.
Looks good to me!
Two things:
- It would be great if you could write a bit more in the docstrings, using the reStructuredText format; this will allow us to populate the API docs automatically
- We started using pytest for testing instead of notebooks, although we only have them for the datastore at the moment; if you want to try and have tests like that for fairness it'd be great, but no pressure
Also go ahead and add those two issues.
| @@ -82,7 +91,8 @@ def __init__(self, cfg_dir: str, spark: bool = True): | |||
| self.mobiledata: SparkDataFrame | |||
| self.mobilemoney: SparkDataFrame | |||
| self.antennas: SparkDataFrame | |||
| self.shapefiles: Union[Dict[str, GeoDataFrame]] = {} | |||
| # TODO: was this supoposed to be a TypedDict? | |||
There was a problem hiding this comment.
That's supposed to be the dictionary of shapefiles for tower voronois and/or admin units. I think the union part is a mistake, and we can change Dict to Mapping
| @@ -29,7 +29,8 @@ def __init__(self, | |||
| clean_folders: bool = False) -> None: | |||
| self.cfg = datastore.cfg | |||
| self.ds = datastore | |||
| self.outputs = datastore.outputs + 'featurizer/' | |||
| self.outputs = datastore.outputs + '/featurizer/' | |||
| self.spark_outputs = datastore.spark_outputs + '/featurizer/' | |||
There was a problem hiding this comment.
Another thing we should do is change all these statements to os.path.join - feel free to do it or we can leave it for later
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two things:
TODO:
(Let me know if you'd like me to make issues for these)