Issue#602 support for media #180
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GlobalDigitalLibraryio/issues#
…in order to get all flagged books (#173)
…lLibraryio/book-api into Issue#602-Support-for-media
gunnarvelle
reviewed
Feb 21, 2020
| @ApiModel(description = "Information about about a media element") | ||
| case class Media(@(ApiModelProperty@field)(description = "URL to the details about the media") url: String, | ||
| @(ApiModelProperty@field)(description = "Always set to 'image', 'audio' or 'video'") `type`: String, | ||
| @(ApiModelProperty@field)(description = "Image id of the media") id: String) |
There was a problem hiding this comment.
Her skulle det kanskje være "Id of the media".
| @@ -21,6 +21,7 @@ trait ContentConverter { | |||
| val contentConverter: ContentConverter | |||
|
|
|||
| class ContentConverter extends LazyLogging { | |||
| // TODO: VIDEO - write a v2 of tis that supports also video or rewrite it so support video and be backward compatible? | |||
There was a problem hiding this comment.
Er disse gjort? Då bør TODO slettes.
| @@ -282,6 +282,7 @@ trait WriteService { | |||
| person)) | |||
| } | |||
| } | |||
| // TODO use v2? | |||
| rendererBuilder | ||
| } | ||
|
|
||
| // TODO: V2 must rewrite this to get right chapter images... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vi har laget V2 av alle eksisterende controllere osv som blir berørt av det at vi skal støtte flere typer enn bare IMAGE. Dette er for at det skal være enkelt å bare kunne deprecate og slette V1 og rename når den tid kommer.
Vi har gjort følgende:
Translation-tabellen med et felt for å finne ut hva slags type bok det er snakk om (vanlig bok med bilder, eller en bok med video). Dette for å lettere kunne vise det frem på ønskelig måte i frontend bla.Det er veldig fint om andre også kjører opp denne versjonen lokalt og ser om de får testet det litt og ellers kommer med ting som de ser er manglende osv :)
Denne versjonen ligger i test også.